Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/src/lints/proper_super_calls/proper_super_calls_rule.dart
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,10 @@ class ProperSuperCallsRule extends SolidLintRule {
final firstStatement = statements.first;

if (firstStatement is ExpressionStatement) {
final expression = firstStatement.expression;
var expression = firstStatement.expression.unParenthesized;
if (expression is AwaitExpression) {
expression = expression.expression.unParenthesized;
}

final isSuperInitStateCalledFirst = expression is MethodInvocation &&
expression.target is SuperExpression &&
Expand All @@ -158,7 +161,10 @@ class ProperSuperCallsRule extends SolidLintRule {
final lastStatement = statements.last;

if (lastStatement is ExpressionStatement) {
final expression = lastStatement.expression;
var expression = lastStatement.expression.unParenthesized;
if (expression is AwaitExpression) {
expression = expression.expression.unParenthesized;
}

final lastStatementIsSuperDispose = expression is MethodInvocation &&
expression.target is SuperExpression &&
Expand Down
52 changes: 52 additions & 0 deletions lint_test/proper_super_calls_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,55 @@ abstract interface class Disposable {
/// Abstract methods should be omitted by `proper_super_calls`
void dispose();
}

class ProperSuperCallsTest3 extends StatefulWidget {
@override
State<ProperSuperCallsTest3> createState() => _ProperSuperCallsTest3State();

ProperSuperCallsTest3();
}

class _ProperSuperCallsTest3State extends State<ProperSuperCallsTest3> {
@override
Widget build() {
return Widget();
}

@override
Future<void> initState() async {
await super.initState();
print('');
}

@override
Future<void> dispose() async {
print('');
await super.dispose();
}
}

class ProperSuperCallsTest4 extends StatefulWidget {
@override
State<ProperSuperCallsTest4> createState() => _ProperSuperCallsTest4State();

ProperSuperCallsTest4();
}

class _ProperSuperCallsTest4State extends State<ProperSuperCallsTest4> {
@override
Widget build() {
return Widget();
}

@override
Future<void> initState() async {
await (super.initState());
print('');
}

@override
Future<void> dispose() async {
print('');
(await super.dispose());
}
}
Loading