Skip to content

Conversation

@reyesmfabian
Copy link
Contributor

Update vlc native library to add support for devices with 16k PAGE_SIZE:

https://code.videolan.org/videolan/libvlcjni/-/issues/11

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @reyesmfabian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flutter_vlc_player plugin's compatibility by updating its underlying Android VLC library. The primary goal is to ensure seamless video playback on Android devices that utilize a 16KB page size, addressing a known issue and broadening the range of supported hardware.

Highlights

  • Android Compatibility: The Android VLC native library has been updated to support devices with a 16KB PAGE_SIZE, resolving compatibility issues on such devices.
  • Dependency Update: The libvlc-all Android dependency has been updated from version 3.6.0-eap14 to 3.6.3.
  • Version Bump: The plugin version has been incremented from 7.4.3 to 7.4.4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the native VLC library for Android to version 3.6.3, which adds support for devices with a 16k page size. The version number in pubspec.yaml and the CHANGELOG.md have been updated accordingly. The changes are straightforward and correct. I've added a couple of minor suggestions to improve formatting consistency in the changelog.

reyesmfabian and others added 2 commits August 30, 2025 11:45
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Collaborator

@illia-romanenko illia-romanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@reyesmfabian
Copy link
Contributor Author

@illia-romanenko dependencies issue solved

@mvn-quannguyen2-dn
Copy link

@reyesmfabian Thank you very much.

@illia-romanenko Do you have any plans on when to release a new version that supports 16KB Page for the VLC Plugin?

@illia-romanenko illia-romanenko merged commit 988a7e6 into solid-software:master Sep 25, 2025
1 of 5 checks passed
@jorelkimcruz
Copy link

jorelkimcruz commented Sep 25, 2025

@illia-romanenko @reyesmfabian hello,

Experiencing this right now.

#546
Screenshot 2025-09-25 at 2 54 52 PM

Also tested it with flutter 3.53.3

Screenshot 2025-09-25 at 3 17 04 PM

Tested on Android 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants