Skip to content

fix(web): 멘토찾기 lazy loading 제거#514

Merged
manNomi merged 1 commit intomainfrom
fix/remove-mentor-lazyload
May 4, 2026
Merged

fix(web): 멘토찾기 lazy loading 제거#514
manNomi merged 1 commit intomainfrom
fix/remove-mentor-lazyload

Conversation

@manNomi
Copy link
Copy Markdown
Contributor

@manNomi manNomi commented May 4, 2026

변경 내용

  • /mentorMentorClient에서 lazy + Suspense 제거
  • MenteePage, MentorPage를 static import로 전환
  • 렌더 분기 로직(멘토/멘티 판단) 유지

목적

  • 멘토찾기 진입 시 발생하던 Suspense fallback 기반 로딩 깜빡임 제거

검증

  • pnpm --filter @solid-connect/web typecheck
  • pnpm --filter @solid-connect/web lint:check
  • pre-push hook에서 ci:check + next build 통과

@manNomi manNomi requested review from enunsnv and wibaek as code owners May 4, 2026 08:23
@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connection-web Ready Ready Preview, Comment May 4, 2026 8:26am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped May 4, 2026 8:26am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 343b6380-d5b4-433d-83cb-1068d91ebb8a

📥 Commits

Reviewing files that changed from the base of the PR and between 6dd12bc and cbaa2c8.

📒 Files selected for processing (1)
  • apps/web/src/app/mentor/_ui/MentorClient/index.tsx

Walkthrough

이 변경사항은 MentorClient 컴포넌트의 로딩 전략을 재설계한 것입니다. 다음과 같이 정리됩니다:

  1. 동적 로딩 제거: lazySuspense를 통한 지연 로딩 방식을 정적 import로 변경했습니다.
  2. import 문 최적화: React에서 lazy/Suspense 제거 대신 useEffect/useState를 명시적으로 추가했습니다.
  3. 렌더링 로직 단순화: Suspense 래퍼와 CloudSpinnerPage 폴백을 제거하고, clientRole에 따라 페이지를 직접 조건부 반환하는 방식으로 변경했습니다.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • wibaek
  • enunsnv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR 설명이 필수 섹션을 포함하지만, 저장소 템플릿의 권장 구조와 비교하면 일부 섹션이 누락되었습니다. 저장소 템플릿에 따라 '관련 이슈' 섹션을 추가하고, '특이 사항'과 '리뷰 요구사항' 섹션을 채워주시기 바랍니다.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경사항의 핵심을 명확하게 요약하고 있습니다. 'lazy loading 제거'는 파일의 주요 변경 내용과 정확히 일치합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-mentor-lazyload

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the web label May 4, 2026
@manNomi manNomi merged commit 5d9ccfc into main May 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant