Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 53 minutes and 18 seconds.Comment |
manNomi
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea99d6df8f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (trimmedSrc.startsWith("//")) return `https:${trimmedSrc}`; | ||
| if (!cdnHostType) return trimmedSrc; | ||
| if (trimmedSrc.startsWith("//")) return normalizeImageUrlToUploadCdn(`https:${trimmedSrc}`); | ||
| if (trimmedSrc.startsWith("/")) return trimmedSrc; |
There was a problem hiding this comment.
resolveCdnUrl now returns any "/..." source immediately, which bypasses cdnHostType host resolution. For call sites like ProfileWithBadge that pass cdnHostType="upload", slash-prefixed API keys (for example /profile/abc.png) are now requested from the web origin instead of the CDN and will 404/fall back. This is a behavioral regression from the previous implementation, which normalized both prefixed and unprefixed relative keys onto the CDN host.
Useful? React with 👍 / 👎.
| if (trimmed.startsWith("blob:") || trimmed.startsWith("data:") || trimmed.startsWith("/")) { | ||
| return trimmed; |
There was a problem hiding this comment.
The admin URL normalizer treats any value starting with / as already-resolved and returns it unchanged. After this commit, GPA/language report links use this helper, so slash-prefixed report keys (for example /scores/report.pdf) now open against the admin app origin instead of the CDN object URL. Previously these links were explicitly prefixed with VITE_S3_BASE_URL, so this change can break report downloads for relative-path data.
Useful? React with 👍 / 👎.
1 participant
요약
cdn.upload.solid-connection.com으로 통일했습니다./images,/svgs),blob:,data:, 외부 도메인 URL은 그대로 유지합니다.FallbackImage의cdnHostType인터페이스는 호환성을 유지하고,default는 내부적으로 upload alias로 동작합니다.변경 사항
apps/web/src/utils/cdnUrl.tsconvertUploadedImageUrl/convertImageUrl를 공통 정규화 로직으로 통합FallbackImage가 원격 URL 및 상대 key를 upload CDN 기준으로 해석하도록 변경apps/admin/src/lib/utils/cdnUrl.tsURL 정규화 규칙
https://cdn.default.solid-connection.com/...https://solid-connection.s3.ap-northeast-2.amazonaws.com/...https://s3.ap-northeast-2.amazonaws.com/solid-connection/...foo/bar.png같은 상대 key/images/...,/svgs/...blob:*,data:*검증
pnpm --filter web run lint:checkpnpm --filter web run typecheck:cipnpm --filter admin run lint:checkpnpm --filter admin run typecheck:citsx기반 URL 변환 케이스 확인