Psi selector#1

Open

gverbock wants to merge 88 commits intosolegalli:mainfrom

gverbock:psi_selector

Commits on Sep 8, 2021

feat: High level structure of the code
Gilles Verbockhaven
committed
feat: clear code
Gilles Verbockhaven
committed
move psi code to the right place, simplify psi code and set attribute min value for bin
Gilles Verbockhaven
committed

Commits on Sep 9, 2021

feat: adjust to the structure
Gilles Verbockhaven
committed

Commits on Sep 10, 2021

add possibility to switch dataframes
Gilles Verbockhaven
committed
feat: clean code and add tests
Gilles Verbockhaven
committed
feat: Add comments and doc strings
Gilles Verbockhaven
committed
bug: fix wrong referencing
Gilles Verbockhaven
committed
bug: Move binning to feature level and drop na
Gilles Verbockhaven
committed

Commits on Sep 28, 2021

correction after run flake8
Gilles Verbockhaven
committed
correction after run flake8
Gilles Verbockhaven
committed
pre-commit issue
Gilles Verbockhaven
committed
run tox
Gilles Verbockhaven
committed
shorten line with 90 characters
Gilles Verbockhaven
committed
code layout: remove line with more than 88 character
Gilles Verbockhaven
committed

Commits on Sep 29, 2021

adjusments realted to PR
Gilles Verbockhaven
committed
change doc string of class
Gilles Verbockhaven
committed
add file
Gilles Verbockhaven
committed
remove old file
Gilles Verbockhaven
committed

Commits on Sep 30, 2021

feat: remove df in init and allow split accoring to all dimensions
Gilles Verbockhaven
committed
black drop_psi_features
Gilles Verbockhaven
committed
Black correction
Gilles Verbockhaven
committed
remove todo
Gilles Verbockhaven
committed
remove used variables
Gilles Verbockhaven
committed
feat: ensure the dataframe spit can be done on different types
Gilles Verbockhaven
committed
add test on quantile calculation for continuous variable
Gilles Verbockhaven
committed

Commits on Oct 1, 2021

doc: Adjust docstring
Gilles Verbockhaven
committed

Commits on Oct 7, 2021

Correction after 2nd review
Gilles Verbockhaven
committed
bug fix: correct test for psi_ and move place split_col is removed from features
Gilles Verbockhaven
committed

Commits on Oct 8, 2021

Raise error when missing are in the split columns and add PSI formula to docs
Gilles Verbockhaven
committed
Raise error when missing are in the split columns and add PSI formula to docs
Gilles Verbockhaven
committed

Commits on Oct 11, 2021

clean code based on suggestions from PR
Gilles Verbockhaven
committed
clean code based on suggestions from PR
Gilles Verbockhaven
committed

Commits on Oct 14, 2021

adjust the text in the ValueErrors
Gilles Verbockhaven
committed
adjust docs
Gilles Verbockhaven
committed
solve mypy type issue
Gilles Verbockhaven
committed
solve mypy type issue
Gilles Verbockhaven
committed
solve mypy type issue
Gilles Verbockhaven
committed

Commits on Oct 21, 2021

Merge pull request #1 from feature-engine/psi_selector
gverbock
authored

Commits on Oct 29, 2021

add cut_off as attribute when it is not defined
Gilles Verbockhaven
committed
Add series of tests
Gilles Verbockhaven
committed
add DropPSI to init file
Gilles Verbockhaven
committed
fix type error on variables
Gilles Verbockhaven
committed
add tests of column types
Gilles Verbockhaven
committed

Commits on Nov 2, 2021

modified init docstrings
solegalli
committed
adds space to error message
solegalli
committed
removes returns from fit docstring
solegalli
committed
revert to previous stance of cut_off assigment
solegalli
committed
add info on categorical cut to init docstring
solegalli
committed
modify cut-off check
solegalli
committed
adds test estimator
solegalli
committed
modify test import
solegalli
committed
expanded fit attr test
solegalli
committed
remove transform from test
solegalli
committed
reorders init param tests, modifies split col test
solegalli
committed
Changes required to pass check_estimator_selectors
Gilles Verbockhaven
committed
reorders tests, adds todos for missing tests
solegalli
committed
runs isort for sorting imports
solegalli
committed
runs black on files
solegalli
committed
merge changes from PR
Gilles Verbockhaven
committed
changes
Gilles Verbockhaven
committed
add changes from PR
Gilles Verbockhaven
committed
Merge branch 'feature-engine-psi_selector_2' into psi_selector
Gilles Verbockhaven
committed
clarify drift feature in test
Gilles Verbockhaven
committed

Commits on Nov 3, 2021

add assertion to cut_off in split_with_different_types
Gilles Verbockhaven
committed
add test of dataframes in split_using_cut_off
Gilles Verbockhaven
committed
Compare dataframe is test
Gilles Verbockhaven
committed
add tests on transform
Gilles Verbockhaven
committed
add to do on test with missing values
Gilles Verbockhaven
committed
clean tests
Gilles Verbockhaven
committed

Commits on Nov 9, 2021

Adjust doc string for split_distinct and add unit test
Gilles Verbockhaven
committed