Skip to content

feat: add support for NO_DNA#593

Open
AtoMicKraK1n wants to merge 2 commits intosolana-foundation:mainfrom
AtoMicKraK1n:add-support-for-NO_DNA
Open

feat: add support for NO_DNA#593
AtoMicKraK1n wants to merge 2 commits intosolana-foundation:mainfrom
AtoMicKraK1n:add-support-for-NO_DNA

Conversation

@AtoMicKraK1n
Copy link
Copy Markdown

Description

  • Adds NO_DNA detection to CLI
  • Disables interactive UX in NO_DNA mode for key paths touched here
  • Prevents interactive cloud login flow when NO_DNA=1 (returns clear actionable error instead).
  • Forces non-TUI behavior for simnet start in NO_DNA mode.
  • Adds unit tests for env parsing and updates top-level --help text to document automation mode.

Validation

  • cargo fmt
  • cargo check -p surfpool-cli
  • cargo test -p surfpool-cli no_dna
  • manual: NO_DNA=1 ./target/debug/surfpool cloud start is non-interactive and errors clearly.

#569

Copy link
Copy Markdown
Collaborator

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AtoMicKraK1n, thanks for the PR. We've actually removed the cloud crate - can you rebase main?

@AtoMicKraK1n AtoMicKraK1n force-pushed the add-support-for-NO_DNA branch from a352cb6 to fce6dee Compare March 27, 2026 04:28
@AtoMicKraK1n
Copy link
Copy Markdown
Author

AtoMicKraK1n commented Mar 27, 2026

Hey @AtoMicKraK1n, thanks for the PR. We've actually removed the cloud crate - can you rebase main?

Rebased onto latest and pushed! Could you please take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants