[testing] changing default local test-validator address from localhost to 127.0.0.1

[ochaloup]

I'm inspired with the change of the solana labs example here solana-labs/example-helloworld#375
From the newer nodejs servers the localhost is resolved to ipv6 ::1 and when I use the AnchorProvider.env() then the ANCHOR_PROVIDER_URL by anchor test is setup to http://localhost:8899.
But the test validator is running on ipv4 as far as I can see.

When I want to use a new instance of Connection that's created with the provider.connection.rpcEndpoint then I'm getting errors like Error: failed to get recent blockhash: TypeError: fetch failed.

Would that be reasonable to change the default local connection url to test validator from localhost to 127.0.0.1?

[vercel]

@ochaloup is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

[acheroncrypto]

I think this is a reasonable change given Node 17 no longer prioritizes IPv4 adresses and made localhost resolution host specific in nodejs/node#39987

Could you add a CHANGELOG entry before we merge?

[ochaloup]

@acheroncrypto I changed the changelog. Please, take a look if the text makes sense.

[acheroncrypto]

Thanks for updating! Small clarification for the following statement:

NodeJS 17 IP resolution changes for IPv6

My understanding is, this is not entirely correct because they didn't change the resolution to IPv6, they just stopped manually overriding to always prioritize IPv4 so it now depends on how your machine is configured to resolve localhost. If they did override to IPv6, our CI which is on Node v18 would not work with localhost. In any case, this is a small detail so we can merge as is.