Skip to content

Conversation

@svazquezco
Copy link
Contributor

@svazquezco svazquezco commented Jan 19, 2026

Closes MPT-16714

  • Update mypy hook revision from v1.17.0 to v1.19.0 in pre-commit configuration
  • Upgrade dev mypy dependency from 1.15.* to 1.19.* in pyproject.toml
  • Reorganize mypy configuration by consolidating settings (ignore_missing_imports, strict, local_partial_types, warn_unreachable) and adding exclude_gitignore = true, replacing the previous exclude = ["tests"] configuration

@svazquezco svazquezco requested a review from a team as a code owner January 19, 2026 14:42
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Mypy tooling versions are updated from v1.17.0 to v1.19.0 in pre-commit configuration and from 1.15.* to 1.19.* in project dependencies. Mypy settings in pyproject.toml are reorganized with the addition of exclude_gitignore = true.

Changes

Cohort / File(s) Summary
Mypy Tooling Updates
.pre-commit-config.yaml, pyproject.toml
Version bump for mypy hook (v1.17.0 → v1.19.0) and dev dependency (1.15.* → 1.19.*). Mypy configuration settings in pyproject.toml relocated with exclude_gitignore = true added and exclude = ["tests"] replaced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains the Jira issue key MPT-16714 in the correct format at the beginning, following the expected MPT-XXXX pattern.
Test Coverage Required ✅ Passed Pull request only modifies configuration files (.pre-commit-config.yaml and pyproject.toml) for updating mypy versions and settings. No actual code files are modified, so test coverage is not required.
Single Commit Required ✅ Passed The pull request contains exactly one commit (606c92c feat: update mypy config from template), which satisfies the requirement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@d3rky d3rky merged commit 4fcb726 into main Jan 19, 2026
4 checks passed
@d3rky d3rky deleted the MPT-16714-update-mypy-config branch January 19, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants