Skip to content

Conversation

@albertsola
Copy link
Contributor

@albertsola albertsola commented Dec 15, 2025

Summary by CodeRabbit

  • Chores
    • Removed the seed system (account and catalog seeding workflows), dependency-injection container, context utilities, and program entry point for seeding.
    • Deleted static resource references used by seeding.
    • Removed all unit tests related to the seeding components.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Walkthrough

The entire seed package and its tests were removed, including account and catalog seed modules, DI container, context and helper utilities, static resource paths, orchestration entry points, and all related unit tests.

Changes

Cohort / File(s) Summary
Seed package: accounts seeding
seed/accounts/accounts.py, seed/accounts/api_tokens.py, seed/accounts/buyer.py, seed/accounts/licensee.py, seed/accounts/module.py, seed/accounts/seller.py, seed/accounts/user_group.py
Removed all account-related seeding modules (data builders, create functions, and seed orchestration for accounts, API tokens, buyers, licensees, modules, sellers, and user groups).
Seed package: catalog seeding
seed/catalog/authorization.py, seed/catalog/catalog.py, seed/catalog/listing.py, seed/catalog/price_list.py, seed/catalog/product.py
Removed all catalog-related seeding modules and the catalog orchestrator (authorizations, listings, price lists, products and related helpers).
Seed package: infrastructure
seed/container.py, seed/context.py, seed/helper.py, seed/main.py, seed/seed_api.py
Removed dependency injection container, context management and persistence, helper utilities (require_context_id, init_resource, ResourceRequiredError), program entry point, and seed orchestration logic.
Seed package: static assets
seed/static/static.py
Removed static asset path constants and pathlib import (ICON, LOGO, PDF).
Test suite: account seeding tests
tests/seed/accounts/test_accounts.py, tests/seed/accounts/test_api_tokens.py, tests/seed/accounts/test_buyer.py, tests/seed/accounts/test_licensee.py, tests/seed/accounts/test_module.py, tests/seed/accounts/test_seller.py, tests/seed/accounts/test_user_group.py
Removed all unit tests for account seeding functionality.
Test suite: catalog seeding tests
tests/seed/catalog/test_authorization.py, tests/seed/catalog/test_catalog.py, tests/seed/catalog/test_listing.py, tests/seed/catalog/test_price_list.py, tests/seed/catalog/test_product.py
Removed all unit tests for catalog seeding functionality.
Test suite: core infrastructure tests
tests/seed/conftest.py, tests/seed/test_context.py, tests/seed/test_helper.py, tests/seed/test_seed_api.py
Removed test fixtures and tests covering context, helper utilities, and seed orchestration.
Test package documentation
tests/seed/__init__.py
Removed module docstring.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

  • Large-scale, intentional removals across ~30 files; homogeneous deletions reduce per-file logic review but require verification of external references.
  • Files/areas to inspect closely:
    • Any remaining imports elsewhere referencing seed.* modules
    • CI/deployment scripts or docs expecting seed entry points or context.json
    • Consumer code that relied on Container, Context, or init_resource behavior

Possibly related PRs

Suggested reviewers

  • d3rky
  • ruben-sebrango
  • svazquezco
  • alephsur
  • robcsegal

Poem

🐰 I hopped through files at break of day,

Pulled the seeds and swept them away,
No sprouts remain in code or log,
A quiet patch — a tidy log,
Now I nap beneath the binary hay. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'MPT-16430 Remove seeding' clearly and accurately describes the main change: the complete removal of the seeding module and all related functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch MPT-16430_remove-seeding

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c91601c and 9c0c0b3.

⛔ Files ignored due to path filters (3)
  • seed/static/FIL-9920-4780-9379.png is excluded by !**/*.png
  • seed/static/empty.pdf is excluded by !**/*.pdf
  • seed/static/logo.png is excluded by !**/*.png
📒 Files selected for processing (35)
  • seed/accounts/accounts.py (0 hunks)
  • seed/accounts/api_tokens.py (0 hunks)
  • seed/accounts/buyer.py (0 hunks)
  • seed/accounts/licensee.py (0 hunks)
  • seed/accounts/module.py (0 hunks)
  • seed/accounts/seller.py (0 hunks)
  • seed/accounts/user_group.py (0 hunks)
  • seed/catalog/authorization.py (0 hunks)
  • seed/catalog/catalog.py (0 hunks)
  • seed/catalog/listing.py (0 hunks)
  • seed/catalog/price_list.py (0 hunks)
  • seed/catalog/product.py (0 hunks)
  • seed/container.py (0 hunks)
  • seed/context.py (0 hunks)
  • seed/helper.py (0 hunks)
  • seed/main.py (0 hunks)
  • seed/seed_api.py (0 hunks)
  • seed/static/static.py (0 hunks)
  • tests/seed/__init__.py (0 hunks)
  • tests/seed/accounts/test_accounts.py (0 hunks)
  • tests/seed/accounts/test_api_tokens.py (0 hunks)
  • tests/seed/accounts/test_buyer.py (0 hunks)
  • tests/seed/accounts/test_licensee.py (0 hunks)
  • tests/seed/accounts/test_module.py (0 hunks)
  • tests/seed/accounts/test_seller.py (0 hunks)
  • tests/seed/accounts/test_user_group.py (0 hunks)
  • tests/seed/catalog/test_authorization.py (0 hunks)
  • tests/seed/catalog/test_catalog.py (0 hunks)
  • tests/seed/catalog/test_listing.py (0 hunks)
  • tests/seed/catalog/test_price_list.py (0 hunks)
  • tests/seed/catalog/test_product.py (0 hunks)
  • tests/seed/conftest.py (0 hunks)
  • tests/seed/test_context.py (0 hunks)
  • tests/seed/test_helper.py (0 hunks)
  • tests/seed/test_seed_api.py (0 hunks)
💤 Files with no reviewable changes (35)
  • tests/seed/init.py
  • tests/seed/accounts/test_module.py
  • seed/catalog/authorization.py
  • seed/catalog/price_list.py
  • tests/seed/catalog/test_catalog.py
  • seed/catalog/product.py
  • tests/seed/test_seed_api.py
  • tests/seed/conftest.py
  • tests/seed/accounts/test_licensee.py
  • seed/context.py
  • seed/main.py
  • seed/container.py
  • tests/seed/accounts/test_seller.py
  • tests/seed/accounts/test_buyer.py
  • tests/seed/accounts/test_user_group.py
  • tests/seed/catalog/test_product.py
  • seed/static/static.py
  • seed/accounts/api_tokens.py
  • tests/seed/test_context.py
  • tests/seed/accounts/test_api_tokens.py
  • tests/seed/catalog/test_listing.py
  • tests/seed/catalog/test_authorization.py
  • seed/accounts/user_group.py
  • tests/seed/accounts/test_accounts.py
  • seed/accounts/buyer.py
  • tests/seed/catalog/test_price_list.py
  • seed/seed_api.py
  • seed/catalog/catalog.py
  • seed/accounts/module.py
  • seed/accounts/seller.py
  • tests/seed/test_helper.py
  • seed/accounts/licensee.py
  • seed/helper.py
  • seed/accounts/accounts.py
  • seed/catalog/listing.py

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Warnings
⚠️

This PR changes 1776 lines across 43 files (threshold: 600). Please consider splitting it into smaller PRs for easier review.

✅ Found Jira issue key in the title: MPT-16430

Generated by 🚫 dangerJS against 9c0c0b3

@albertsola albertsola force-pushed the MPT-16430_remove-seeding branch from c91601c to 9c0c0b3 Compare December 17, 2025 08:56
@sonarqubecloud
Copy link

@d3rky d3rky merged commit 5ffcc88 into main Dec 17, 2025
6 of 7 checks passed
@d3rky d3rky deleted the MPT-16430_remove-seeding branch December 17, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants