-
Notifications
You must be signed in to change notification settings - Fork 0
MPT-15271: add flake8 pyproject and flake8 aaa #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPT-15271: add flake8 pyproject and flake8 aaa #134
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 37 files out of 144 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
✅ Found Jira issue key in the title: MPT-15271 |
| @pytest.mark.skip(reason="Leaves test products in the catalog") # noqa: AAA01 | ||
| @pytest.mark.flaky | ||
| def test_product_review_and_publish(mpt_vendor, mpt_ops, created_product): | ||
| mpt_vendor.catalog.products.review(created_product.id) | ||
| mpt_ops.catalog.products.publish(created_product.id) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood
|



Add:
Fix the tests to follow the flake8-aaa rules. Note that we are following these solutions to address rules AAA01 and AAA03 rule
AAA01:


AAA03: we follow the large-style act block approach
