Skip to content

Conversation

@svazquezco
Copy link
Contributor

@svazquezco svazquezco commented Nov 26, 2025

Add:

Fix the tests to follow the flake8-aaa rules. Note that we are following these solutions to address rules AAA01 and AAA03 rule

AAA01:
image
image

AAA03: we follow the large-style act block approach
image

@svazquezco svazquezco changed the title Mpt 15271add flake8 pyproject and flake8 aaa MPT-15271add flake8 pyproject and flake8 aaa Nov 26, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

37 files out of 144 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch MPT-15271-add-flake8-pyproject-and-flake8-aaa

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Warnings
⚠️

This PR changes 4258 lines across 145 files (threshold: 600). Please consider splitting it into smaller PRs for easier review.

⚠️

This PR contains 3 commits.

Please squash them into a single commit to keep the git history clean and easy to follow.

Multiple commits are acceptable only in the following cases:

  1. One commit is a technical refactoring, and another introduces business logic changes.
  2. You are doing a complex multi-step refactoring (although in this case we still recommend splitting it into separate PRs).

✅ Found Jira issue key in the title: MPT-15271

Generated by 🚫 dangerJS against d37226f

@svazquezco svazquezco changed the title MPT-15271add flake8 pyproject and flake8 aaa MPT-15271: add flake8 pyproject and flake8 aaa Nov 26, 2025
Comment on lines 35 to 40
@pytest.mark.skip(reason="Leaves test products in the catalog") # noqa: AAA01
@pytest.mark.flaky
def test_product_review_and_publish(mpt_vendor, mpt_ops, created_product):
mpt_vendor.catalog.products.review(created_product.id)
mpt_ops.catalog.products.publish(created_product.id)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood

@sonarqubecloud
Copy link

@albertsola albertsola merged commit 3399c94 into main Nov 27, 2025
5 of 6 checks passed
@albertsola albertsola deleted the MPT-15271-add-flake8-pyproject-and-flake8-aaa branch November 27, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants