MPT-14890 Tests for catalog/product/media #125
Conversation
albertsola
requested review from
alephsur,
d3rky,
jentyk,
robcsegal,
ruben-sebrango and
svazquezco
as code owners
albertsola
force-pushed
the
e2e/catalog/MPT-14890-tests-for-product-media
branch
from
c9c7f2a to
1375b24
Compare
albertsola
force-pushed
the
e2e/catalog/MPT-14890-tests-for-product-media
branch
from
1375b24 to
1ac1861
Compare
mpt_api_client/http/async_client.py
Outdated
|
|
||
| from mpt_api_client.constants import APPLICATION_JSON | ||
| from mpt_api_client.exceptions import MPTError, transform_http_status_exception | ||
| from mpt_api_client.http.mixins import _json_to_file_payload |
There was a problem hiding this comment.
Why are we importing a private method here? I wonder why the PLC2701 wasn't raised by the linter
There was a problem hiding this comment.
Good catch, we are moving that functionality from mixins to client. Temporary is in both places.
I have moved it to the http.client now.
@robcsegal will refactor the rest of the mixins to remove that dependency.
mpt_api_client/http/mixins.py
Outdated
|
|
||
|
|
||
| def _json_to_file_payload(resource_data: ResourceData) -> bytes: | ||
| def _json_to_file_payload(resource_data: ResourceData | None) -> bytes: |
There was a problem hiding this comment.
Why do we have this private method outside of the class? I believe the responsibility for that belongs to the FilesOperationsMixin. If you don't want to duplicate the code you should add a parent class with this method, so it can be inherited by the Async and sync mixins. Or, you can duplicate the code to keep the sync and async logic separated
There was a problem hiding this comment.
We are removing FilesOperationMixin, we are moving all files handling logic into the http.client.
Otherwise each request with a file upload is a copy of FilesOperationMixin with subsequent unit tests.
albertsola
force-pushed
the
e2e/catalog/MPT-14890-tests-for-product-media
branch
from
1ac1861 to
635f194
Compare
albertsola
force-pushed
the
e2e/catalog/MPT-14890-tests-for-product-media
branch
from
635f194 to
1751a85
Compare
|
No description provided.