MPT-14888 Add E2E tests for catalog items #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertsola
requested review from
alephsur,
d3rky,
jentyk,
robcsegal,
ruben-sebrango and
svazquezco
as code owners
albertsola
force-pushed
the
e2e/catalog/MPT-14888-product-items
branch
4 times, most recently
from
1d6108e to
70508af
Compare
d3rky
approved these changes
Nov 14, 2025
albertsola
commented
Nov 14, 2025
| service = async_mpt_vendor.catalog.items | ||
| update_data = {"name": "e2e - delete me (updated)"} | ||
| item = await service.update(async_created_item.id, update_data) | ||
| assert item.name == "e2e - delete me (updated)" |
Contributor
Author
There was a problem hiding this comment.
We could and we do it some times, although this goes against the Requirement 2 of the TDR:
1. E2E tests should check the communication between the client and the real MPT API
2. It shouldn’t test the MPT API itself. Means tests should not check permutations of the cases of the MPT API, and also, it shouldn’t check that MPT creates/updates/deletes entities properly
3. E2E tests should check that simple requests/responses are not failing
For now we try to minimise the request done to the API for performance purposes.
jentyk
reviewed
Nov 14, 2025
albertsola
force-pushed
the
e2e/catalog/MPT-14888-product-items
branch
2 times, most recently
from
3245df1 to
5964e1c
Compare
jentyk
approved these changes
Nov 17, 2025
albertsola
force-pushed
the
e2e/catalog/MPT-14888-product-items
branch
from
5964e1c to
e5590af
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.