fix(Android): setClientRect after drawing wrapped text in TSpanView with inlineSize#2965
Open
dashitongzhi wants to merge 1 commit into
Open
Conversation
…eSize When a TSpan has inlineSize set and contains text content (mContent != null), the draw() method was calling drawWrappedText() which renders the text using StaticLayout but never calling setClientRect(). This caused the onLayout event to fire with incorrect dimensions (height=0, y=0) on Android. The fix: 1. Extract layout creation into createWrappedTextLayout() method that also computes and stores the text position (dx, dy) 2. Call setClientRect() with the proper bounds after drawing the wrapped text 3. Reuse the same layout for both fill and stroke painting This ensures the nativeEvent.layout in onLayout callback receives correct width, height, x, and y values when using inlineSize on TSpan elements. Fixes issue software-mansion#1257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #1257. TSpanView.java now calls setClientRect() after drawing wrapped text with inlineSize on Android.