Resolve worklets via gradle#8866
Closed
radoslawrolka wants to merge 1 commit intosoftware-mansion:mainfrom
Closed
Conversation
Member
|
Let's also revert other changes that were introduced in #7866. |
Collaborator
|
Closing in favor of #8685 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the way react-native-reanimated depends on react-native-worklets in its Android native build. Instead of directly linking to the worklets .so file (hardcoded path), it uses CMake's find_package to locate the worklets config package.
This approach leverages CMake's package management capabilities. It ensures that the worklets library is properly found and linked during the build process, even if the build output paths change. This also aligns with best practices for managing dependencies in CMake-based projects.
Also resolves the build order issues in RNRepo when libraries configuration is changed with precompiled packages.
NOTE: tested on basic RN apps, not in more complex setups like monorepos or other.
Test plan