Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces ESLint’s built-in (non-autofixable) import sorting with eslint-plugin-simple-import-sort, and applies the new import/export ordering across the repo.
Changes:
- Add
eslint-plugin-simple-import-sortand enablesimple-import-sort/imports+simple-import-sort/exportsrules. - Apply automated import/export ordering changes across package + example app sources.
- Update a few modules’ export ordering and some asset imports to align with the new sorting rules.
Reviewed changes
Copilot reviewed 287 out of 288 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds lockfile entry for eslint-plugin-simple-import-sort. |
| package.json | Adds eslint-plugin-simple-import-sort to devDependencies. |
| .eslintrc.json | Registers simple-import-sort plugin and enables import/export sorting rules. |
| packages/react-native-gesture-handler/src/web/utils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/tools/WheelEventManager.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/tools/PointerEventManager.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/tools/NodeManager.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/tools/KeyboardEventManager.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/tools/InteractionManager.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/tools/GestureHandlerWebDelegate.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/tools/GestureHandlerOrchestrator.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/interfaces.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/TapGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/RotationGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/PinchGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/PanGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/NativeViewGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/ManualGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/LongPressGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/IGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/HoverGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/GestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/handlers/FlingGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/web/detectors/ScaleGestureDetector.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/types/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/v3/types/UtilityTypes.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/types/NativeWrapperType.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/types/EventTypes.ts | Import grouping/spacing update. |
| packages/react-native-gesture-handler/src/v3/types/DetectorTypes.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/utils/reanimatedUtils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/utils/propsWhiteList.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/utils/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/utils/eventUtils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/utils/eventHandlersUtils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/utils/configUtils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/useGestureCallbacks.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/useGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/tap/useTapGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/rotation/useRotationGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/pinch/usePinchGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/pan/usePanGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/pan/PanTypes.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/native/useNativeGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/manual/useManualGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/longPress/useLongPressGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/hover/useHoverGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/hover/HoverTypes.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/gestures/fling/useFlingGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/composition/useComposedGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/composition/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/callbacks/useReanimatedEventHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/callbacks/useGestureEventHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/callbacks/updateHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/callbacks/touchEventHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/callbacks/stateChangeHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/hooks/callbacks/eventHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/gestureStateManager.web.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/utils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/useEnsureGestureHandlerRootView.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/common.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/VirtualDetector/useInterceptingDetectorContext.ts | Import grouping/spacing update. |
| packages/react-native-gesture-handler/src/v3/detectors/VirtualDetector/VirtualDetector.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/VirtualDetector/InterceptingGestureDetector.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/ReanimatedNativeDetector.web.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/ReanimatedNativeDetector.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/NativeDetector.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/HostGestureDetector.web.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/detectors/GestureDetector.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/createNativeWrapper.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/components/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/v3/components/Touchable/TouchableProps.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/components/Touchable/Touchable.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/components/Pressable.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/components/GestureComponents.web.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/components/GestureComponents.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/components/GestureButtonsProps.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/components/GestureButtons.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/NativeProxy.web.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/v3/NativeProxy.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/specs/RNGestureHandlerRootViewNativeComponent.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/specs/RNGestureHandlerDetectorNativeComponent.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/specs/NativeRNGestureHandlerModule.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/mocks/gestureComponents.tsx | Export ordering update. |
| packages/react-native-gesture-handler/src/mocks/GestureButtons.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/jestUtils/jestUtils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/jestUtils/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/index.ts | Export ordering update for public API surface. |
| packages/react-native-gesture-handler/src/handlers/utils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/handlersRegistry.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/tapGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/rotationGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/reanimatedWrapper.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/pinchGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/panGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/nativeGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/manualGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/longPressGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/hoverGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/gestureStateManager.web.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/gestureObjects.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/gestureComposition.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/gesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/forceTouchGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/flingGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/eventReceiver.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/utils.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/useViewRefHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/useMountReactions.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/useDetectorUpdater.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/useAnimatedGesture.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/updateHandlers.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/types.ts | Import ordering + changes AttachedGestureState export form. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/needsToReattach.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/index.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/dropHandlers.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/attachHandlers.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/Wrap.web.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/Wrap.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestureHandlerTypesCompat.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/gestureHandlerCommon.ts | Import grouping/spacing update. |
| packages/react-native-gesture-handler/src/handlers/createNativeWrapper.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/createHandler.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/TapGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/RotationGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/PinchGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/PanGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/NativeViewGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/LongPressGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/ForceTouchGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/handlers/FlingGestureHandler.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/findNodeHandle.web.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/components/touchables/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/components/touchables/TouchableWithoutFeedback.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/touchables/TouchableOpacity.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/touchables/TouchableNativeFeedbackProps.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/touchables/TouchableNativeFeedback.android.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/touchables/TouchableHighlight.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/touchables/GenericTouchableProps.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/components/touchables/GenericTouchable.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/Text.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/ReanimatedSwipeable/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeableProps.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeable.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/ReanimatedDrawerLayout.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/Pressable/utils.ts | Import ordering + export ordering update. |
| packages/react-native-gesture-handler/src/components/Pressable/stateDefinitions.ts | Import grouping/spacing update. |
| packages/react-native-gesture-handler/src/components/Pressable/index.ts | Export ordering update. |
| packages/react-native-gesture-handler/src/components/Pressable/PressableProps.tsx | Import grouping/spacing update. |
| packages/react-native-gesture-handler/src/components/Pressable/Pressable.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/GestureHandlerRootView.web.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/GestureHandlerRootView.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/GestureHandlerRootView.android.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/GestureHandlerButton.tsx | Import grouping/spacing update. |
| packages/react-native-gesture-handler/src/components/GestureComponents.web.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/GestureComponents.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/components/GestureButtonsProps.ts | Import grouping/spacing update. |
| packages/react-native-gesture-handler/src/components/GestureButtons.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/tests/mocks.test.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/tests/api_v3.test.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/tests/RelationsTraversal.test.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/tests/Events.test.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/tests/Errors.test.tsx | Import ordering update. |
| packages/react-native-gesture-handler/src/RNGestureHandlerModule.windows.ts | Import ordering update. |
| packages/react-native-gesture-handler/src/RNGestureHandlerModule.web.ts | Import ordering update. |
| apps/common-app/src/new_api/tests/webStylesReset/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/twoFingerPan/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/rectButton/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/reattaching/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/pressable/testingBase.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/pressable/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/pressable/hoverDelay.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/pressable/hitSlop.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/pressable/functionalStyles.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/pressable/delayedPress.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/pressable/androidRipple.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/pointerType/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/nestedRootView/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/tests/nestedPressables/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/simple/tap/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/simple/rotation/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/simple/pinch/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/simple/pan/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/simple/longPress/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/simple/hover/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/simple/fling/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/showcase/timer/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/showcase/svg/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/showcase/state_manager/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/showcase/shared_value/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/showcase/overlap/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/showcase/nested_text/nested_text.tsx | Import ordering update. |
| apps/common-app/src/new_api/showcase/bottom_sheet/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/showcase/animated/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/hover_mouse/stylus_data/index.tsx | Import ordering + switches PNG from require to ESM import. |
| apps/common-app/src/new_api/hover_mouse/mouse_buttons/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/hover_mouse/hoverable_icons/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/hover_mouse/hover/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/hover_mouse/context_menu/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/touchable_stress/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/touchable/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/switchAndInput/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/swipeable/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/swipeable/GmailStyleSwipeableRow.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/swipeable/AppleStyleSwipeableRow.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/scrollview/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/flatlist/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/drawer/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/buttons/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/components/button_underlay/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/complicated/velocity_test/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/complicated/lock/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/complicated/chat_heads/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/complicated/camera/index.tsx | Import ordering update. |
| apps/common-app/src/new_api/complicated/camera/filters.tsx | Import ordering update. |
| apps/common-app/src/new_api/complicated/camera/capture.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/velocityTest/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/transformations/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/pressable/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/overlap/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/manualGestures/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/hoverable_icons/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/hover/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/drag_n_drop/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/drag_n_drop/Tile.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/drag_n_drop/Draggable.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/drag_n_drop/DragAndDrop.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/chat_heads/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/camera/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/calculator/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/v2_api/bottom_sheet/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/simple/tap/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/simple/manual/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/simple/longPress/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/simple/fling/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/simple/draggable/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/showcase/chatHeads/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/showcase/bottomSheet/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/webStylesReset/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/twoFingerPan/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/touchables/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/svg/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/rectButton/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/pointerType/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/overflowParent/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/nestedTouchables/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/nestedText/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/nestedPressables/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/nestedGHRootViewWithModal/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/nestedFling/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/nestedButtons/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/mouseButtons/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/gesturizedPressable/testingBase.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/gesturizedPressable/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/gesturizedPressable/hoverDelayExample.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/gesturizedPressable/hitSlopExample.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/gesturizedPressable/functionalStylesExample.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/gesturizedPressable/delayedPressExample.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/gesturizedPressable/androidRippleExample.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/doubleDraggable/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/contextMenu/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/combo/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/combo/InfoButton.tsx | Import ordering update. |
| apps/common-app/src/legacy/release_tests/StylusData/index.tsx | Import ordering + switches PNG from require to ESM import. |
| apps/common-app/src/legacy/recipes/scaleAndRotate/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/recipes/panAndScroll/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/basic/panResponder/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/basic/pagerAndDrawer/index.android.tsx | Import ordering update. |
| apps/common-app/src/legacy/basic/multitap/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/basic/forcetouch/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/basic/fling/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/basic/draggable/index.tsx | Import ordering update. |
| apps/common-app/src/legacy/basic/bouncing/index.tsx | Import ordering update. |
| apps/common-app/src/empty/index.tsx | Import ordering update. |
| apps/common-app/src/common_assets/AnimatedCameraView/AnimatedCameraView.tsx | Import ordering update. |
| apps/common-app/src/common.tsx | Import ordering update (note: contains a type/value import issue flagged in comments). |
| apps/common-app/src/ListWithHeader/index.ts | Export ordering update. |
| apps/common-app/src/ListWithHeader/ListWithHeader.tsx | Import ordering update. |
| apps/common-app/src/ListWithHeader/Header.tsx | Import ordering + switches PNG from require to ESM import. |
| apps/basic-example/src/Text.tsx | Import ordering update. |
| apps/basic-example/src/RuntimeDecoration.tsx | Import ordering update. |
| apps/basic-example/src/Navigator.tsx | Import ordering update. |
| apps/basic-example/src/ContentsButton.tsx | Import ordering update. |
| apps/basic-example/src/App.tsx | Import ordering update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
10
| import type { Platform, StyleProp, ViewStyle } from 'react-native'; | ||
| import { StyleSheet, Text, View } from 'react-native'; |
There was a problem hiding this comment.
Platform is imported using import type, but it’s referenced via typeof Platform.OS (which requires Platform to exist in the value namespace). This will fail type-checking. Import Platform as a normal value import (and keep only StyleProp/ViewStyle as type-only), or replace this with an explicit exported RN type for the OS union if available.
Suggested change
| import type { Platform, StyleProp, ViewStyle } from 'react-native'; | |
| import { StyleSheet, Text, View } from 'react-native'; | |
| import type { StyleProp, ViewStyle } from 'react-native'; | |
| import { Platform, StyleSheet, Text, View } from 'react-native'; |
Comment on lines
1
to
5
| import type { SharedValue } from '../../../v3/types'; | ||
| import type { GestureType, HandlerCallbacks } from '../gesture'; | ||
|
|
||
| export interface AttachedGestureState { | ||
| export default interface AttachedGestureState { | ||
| // Array of gestures that should be attached to the view under that gesture detector |
There was a problem hiding this comment.
This file switches AttachedGestureState to a default export while GestureDetectorState remains a named export. Mixing default + named exports in the same “types” module makes usage inconsistent and forces multiple import styles. Consider keeping AttachedGestureState as a named export (as before) so call sites can import both types from ./types in a single statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Turns out that inbuilt
sort-importcannot be fixed with autofix. I got inspiration from Reanimated and addedsimple-import-sortTest plan
yarn lint-js