fix(ocr): sort boxes within a row left-to-right#1190
Merged
Conversation
groupTextBoxes returned text boxes top-to-bottom but boxes on the same visual row fell back to the earlier descending-side-length ordering, which reads as "by probability" rather than reading order. Adds a second pass: after sorting by top-Y, group consecutive boxes whose top-Y differs by less than half the mean text height and sort each group left-to-right by top-X. A single comparator with soft Y-equality is intentionally avoided — A~B, B~C with A>>C breaks strict weak ordering and is UB under std::sort. Closes #1159
chmjkb
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is potentially a blocker for demo app recordings for promotion purposes.
useOCR().forward(image)returned boxes top-to-bottom but boxes on the same visual row fell back to the earlier descending-side-length ordering — reading as "by probability" rather than reading order.After the final Y-sort in
groupTextBoxes, group consecutive boxes whose top-Y differs by less than half the mean text height and sort each group left-to-right by top-X.Single-comparator soft-Y-equality is intentionally avoided —
A~B,B~CwithAfar fromCviolates strict weak ordering and is UB understd::sort.Introduces a breaking change?
Type of change
Tested on
Testing instructions
computer-visiondemo → OCR screen.Price 12.99 USD).Related issues
Closes #1159