ci: per-app build matrix with precise path triggers by msluszniak · Pull Request #1112 · software-mansion/react-native-executorch

msluszniak · 2026-04-29T16:23:24Z

Description

Replaces the LLM-only build workflows with one matrix-based build-apps.yml, gated by dorny/paths-filter so each app/platform cell runs only when its code or shared infrastructure changes.

Three parallel matrices per push:

a Metro JS bundle (production mode, catches missing imports and transform errors before any native build),
Android native build,
iOS native build.

Cells skip in ~30s via content-hash cache markers when their relevant files haven't changed since the last passing run.

A lint-time drift check fails PRs that introduce source files not covered by any per-app filter.

Adds a Jest smoke test for bare-rn.

Skips all build workflows on draft PRs; fires on ready_for_review.

Introduces a breaking change?

Yes
No

Type of change

Bug fix (change which fixes an issue)
New feature (change which adds functionality)
Documentation update (improves or adds clarity to existing documentation)
Other (chores, tests, code style improvements etc.)

Tested on

Not applicable

Testing instructions

Open as draft — confirm no build workflows run.
Mark ready for review — Example apps build check runs; the matrix contains only the apps whose paths actually changed.
Touch only apps/computer-vision/** — only computer-vision cells run (Android + iOS + bundle).
Touch only packages/react-native-executorch/android/** — only Android native cells run; iOS and bundle skip.
Push a no-op touching only the workflow file — every cell hits its cache marker and finishes in ~30s.
Add a broken import to one app's App.tsx — the bundle cell for that app fails fast before any native build finishes.
Add a tracked file under packages/react-native-executorch/ not matched by any filter — Check CI filter coverage in the lint job fails and lists the uncovered path.

Related issues

Closes #963.

Checklist

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly
My changes generate no new warnings

Additional notes

This PR also fixes notorious iOS CI fails but getting available simulator, not a specific one.

Replaces the LLM-only Android/iOS build workflows with one matrix-based workflow per platform that gates each app's build on `dorny/paths-filter`. Adds coverage for computer-vision, speech, text-embeddings, and bare-rn demos, plus a Jest smoke test for bare-rn. Skips builds on draft PRs and fires on ready_for_review so flipping a draft to ready triggers CI. Closes #963.

msluszniak · 2026-04-29T16:42:55Z

+            computer-vision:
+              - *expo-shared
+              - packages/react-native-executorch/common/rnexecutorch/models/VisionModel.{cpp,h}
+              - packages/react-native-executorch/common/rnexecutorch/models/{classification,instance_segmentation,object_detection,ocr,semantic_segmentation,style_transfer,text_to_image,vertical_ocr}/**


these and speech models should be gathered is a separate PR to separate subdirs to exclude this too long inclusion lines.

…cific device

… hash - bundle job now runs `yarn prepare` before bundling bare-rn so react-native-executorch-bare-resource-fetcher's lib/ exists for metro (Expo apps don't need it; expo export resolves workspace deps directly). - iOS composite caches CocoaPods recipes + installed Pods keyed by Podfile.lock, saving ~3-5 min per cell on cache hits. - compute-app-hash.js excludes .github/workflows/build-apps.yml from the content hash. Workflow edits still trigger the matrix, but each cell hits its existing marker and skips. Build-behavior workflow edits (with:, runs-on:, env:) need a manual cache clear via the UI.

…fy disk free

Pull_request runs scope caches to refs/pull/N/merge, which gets dereferenced when the PR is closed. Switch to a push-driven trigger so caches save against refs/heads/<branch> and survive close/reopen. - push: branches ['**'] covers every commit to every branch. - pull_request: types narrowed to [opened, reopened, ready_for_review] — the events with no corresponding push. - pull_request: synchronize removed (push already covers every commit). - Workflow-level concurrency keyed by event_name + branch so push and pull_request runs don't cancel each other. - Draft status resolved via `gh pr list` for push events, preserving the no-CI-on-drafts rule from #963 even without a pull_request payload.

… wipe them" This reverts commit 0dd4cba.

barhanc

I've tested the CI on a forked repo (barhanc#2) following the instructions and it seems to me that there is some problem with caching:

after pushing changes to apps/computer-vision/** for some reason the Android bare-rn app is not skipped and its build runs (in addition to computer-vision apps), see here: https://github.com/barhanc/react-native-executorch/actions/runs/25800750822/job/75789861221
pushing an added comment to .github/workflows/build-apps.yml rebuilds all iOS apps, but skips Android, e.g.:
- https://github.com/barhanc/react-native-executorch/actions/runs/25803697575/job/75800521119 (Android),
- https://github.com/barhanc/react-native-executorch/actions/runs/25803697575/job/75800520995 (iOS)

The two following commits (broken import and a file not matched by any filter) behave correctly.

msluszniak · 2026-05-13T15:25:18Z

I've tested the CI on a forked repo (barhanc#2) following the instructions and it seems to me that there is some problem with caching:

after pushing changes to apps/computer-vision/** for some reason the Android bare-rn app is not skipped and its build runs (in addition to computer-vision apps), see here: https://github.com/barhanc/react-native-executorch/actions/runs/25800750822/job/75789861221

pushing an added comment to .github/workflows/build-apps.yml rebuilds all iOS apps, but skips Android, e.g.:

https://github.com/barhanc/react-native-executorch/actions/runs/25803697575/job/75800521119 (Android),

https://github.com/barhanc/react-native-executorch/actions/runs/25803697575/job/75800520995 (iOS)

The two following commits (broken import and a file not matched by any filter) behave correctly.

Ok, will investigate it.

msluszniak · 2026-05-14T09:28:10Z

~~Both are testing artifacts, not filter bugs:~~

(1) Your PR adds the workflow file + apps/bare-rn/__mocks__/* + apps/bare-rn/jest.config.js — those legitimately match bare-rn-app. Filter trace from your run confirms: bare-rn matched on those new files, not on the CV edit. Once #1112 lands on main, a future CV-only PR won't trigger bare-rn.

(2) The middle commit wasn't workflow-only — it touched android/CMakeLists.txt, which re-saved the Android marker at 13:42. By 13:55 the iOS marker (from 12:52) had been LRU-evicted under the 10 GB cache quota. Same hash both runs, just one cache still present and the other gone.

Two issues compounded into bare-rn rebuilding on a CV-only push: 1. dorny defaulted to comparing against the PR base, so each push re-evaluated the cumulative PR diff and pulled every app whose filter ever matched into the matrix. Setting `base: event.before || pull_request.base.sha` restricts the diff to just the current push (with PR-base fallback for opened / reopened / ready_for_review). 2. The Gradle (~3 GB) and CocoaPods (~500 MB × 5 iOS apps) caches saved during a single run, plus setup-java's redundant gradle cache, pushed the repo over GitHub's 10 GB cache quota and evicted the tiny (~250 B) build markers under LRU. Cells appeared in the matrix on subsequent pushes (legitimately, per PR-base diff) but missed the cache and rebuilt. Dropping these peer caches so markers survive — markers gate entire build cells, which is worth more than the 3-10 min those caches saved on warm-up.

…l_request)

msluszniak · 2026-05-14T13:14:09Z

@barhanc I changed approach to how diffs are resolved, please could you check again later?

barhanc

I've run the tests again (barhanc#3) and everything worked as expected.

chmjkb

not sure if i have anything to add here regarding the code, but I think it would be nice to have some kind of readme that explains what is going on here and when what needs to be changed
also I'd like to hear what @mkopcins has to say before we merge

msluszniak · 2026-05-22T09:28:42Z

not sure if i have anything to add here regarding the code, but I think it would be nice to have some kind of readme that explains what is going on here and when what needs to be changed also I'd like to hear what @mkopcins has to say before we merge

Agreed, some kind of readme will be helpful for this one.

msluszniak self-assigned this Apr 29, 2026

msluszniak added the chore PRs that are chores label Apr 29, 2026

ci: compact path filters with brace expansion

471403f

msluszniak marked this pull request as draft April 29, 2026 16:41

msluszniak commented Apr 29, 2026

View reviewed changes

ci: build workspace packages before running bare-rn jest

12385c0

msluszniak marked this pull request as ready for review April 29, 2026 16:44

msluszniak added 3 commits April 29, 2026 18:51

ci: merge Android + iOS workflows into one with single filter block

ecbf706

test(bare-rn): mock native packages so smoke test can render

dd34770

ci: use generic iOS Simulator destination so build doesn't need a spe…

c9d2a9f

…cific device

msluszniak marked this pull request as draft April 29, 2026 17:43

msluszniak added 3 commits April 29, 2026 19:49

ci: add Metro bundle check matrix to catch JS errors before native build

2c68b80

ci: fail lint when source files aren't covered by build-apps filter

d1af2ed

ci: skip already-passing app builds via content-hash cache marker

9aef7d0

msluszniak marked this pull request as ready for review April 29, 2026 18:24

msluszniak requested review from NorbertKlockiewicz and chmjkb and removed request for chmjkb April 29, 2026 20:02

chmjkb requested changes May 8, 2026

View reviewed changes

Comment thread scripts/check-ci-filter-coverage.ts

Comment thread scripts/compute-app-hash.ts

Comment thread .github/workflows/docs-build-check.yml

msluszniak added 2 commits May 11, 2026 12:23

ci: rewrite filter-coverage and app-hash scripts in TypeScript

cfcd199

ci: cover pose_estimation and privacy_filter in build-apps filters

bb64376

msluszniak requested review from barhanc and chmjkb May 11, 2026 11:38

barhanc requested changes May 12, 2026

View reviewed changes

Comment thread .github/workflows/build-apps.yml Outdated

Comment thread .github/actions/build-android-app/action.yml

Comment thread .github/actions/build-ios-app/action.yml Outdated

ci: address review — dedupe prepare step, pin Pods cache to v5, justi…

cf4fdb9

…fy disk free

msluszniak requested a review from barhanc May 12, 2026 14:57

barhanc closed this May 13, 2026

barhanc reopened this May 13, 2026

msluszniak closed this May 13, 2026

msluszniak reopened this May 13, 2026

msluszniak marked this pull request as draft May 13, 2026 12:10

Revert "ci: save caches against branch ref so PR close/reopen doesn't…

edf42ab

… wipe them" This reverts commit 0dd4cba.

msluszniak marked this pull request as ready for review May 13, 2026 12:20

barhanc reviewed May 13, 2026

View reviewed changes

msluszniak marked this pull request as draft May 13, 2026 18:26

This was referenced May 14, 2026

test: validate per-app CI matrix pipeline msluszniak/react-native-executorch#4

Closed

test: validate per-app CI matrix pipeline (fork) msluszniak/react-native-executorch#5

Closed

ci: replace dorny with custom git-diff step (push-incremental for pul…

a0bcf39

…l_request)

msluszniak marked this pull request as ready for review May 14, 2026 13:08

msluszniak requested a review from barhanc May 14, 2026 13:09

barhanc approved these changes May 14, 2026

View reviewed changes

chmjkb reviewed May 22, 2026

View reviewed changes

msluszniak added 2 commits May 25, 2026 10:41

docs(ci): add README explaining the per-app build matrix

8c02351

test(bare-rn): mock models registry so post-#1148 App.tsx renders

144b77b

msluszniak requested a review from chmjkb May 25, 2026 08:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: per-app build matrix with precise path triggers#1112

ci: per-app build matrix with precise path triggers#1112
msluszniak wants to merge 19 commits into
mainfrom
@ms/ci-coverage

msluszniak commented Apr 29, 2026 •

edited

Loading

Uh oh!

msluszniak Apr 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barhanc left a comment •

edited

Loading

Uh oh!

msluszniak commented May 13, 2026

Uh oh!

msluszniak commented May 14, 2026 •

edited

Loading

Uh oh!

msluszniak commented May 14, 2026

Uh oh!

barhanc left a comment •

edited

Loading

Uh oh!

chmjkb left a comment

Uh oh!

msluszniak commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

msluszniak commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Introduces a breaking change?

Type of change

Tested on

Testing instructions

Related issues

Checklist

Additional notes

Uh oh!

msluszniak Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barhanc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msluszniak commented May 13, 2026

Uh oh!

msluszniak commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented May 14, 2026

Uh oh!

barhanc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chmjkb left a comment

Choose a reason for hiding this comment

Uh oh!

msluszniak commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

msluszniak commented Apr 29, 2026 •

edited

Loading

barhanc left a comment •

edited

Loading

msluszniak commented May 14, 2026 •

edited

Loading

barhanc left a comment •

edited

Loading