Skip to content

fix(android): block mention events when cursor is inside a finalized mention span #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jianlong-Nie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): block mention events when cursor is inside a finalized mention span #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions android/src/main/java/com/swmansion/enriched/textinput/styles/ParametrizedStyles.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,6 @@ class ParametrizedStyles(
val mentionIndicatorRegex = Regex("^($indicatorsPattern)")
val mentionRegex = Regex("^($indicatorsPattern)\\w*")

val spans = spannable.getSpans(currentWord.start, currentWord.end, EnrichedInputMentionSpan::class.java)
for (span in spans) {
spannable.removeSpan(span)
}

var indicator: String
var finalStart: Int
val finalEnd = currentWord.end
Expand Down Expand Up @@ -259,6 +254,25 @@ class ParametrizedStyles(
indicator = mentionIndicatorRegex.find(currentWord.text)?.value ?: ""
}

// Mirror iOS conflicting-styles behaviour: check the full candidate range for
// a finalized mention span. If the span's stored text still matches what is in
// the buffer the mention is intact — block the event (covers HTML-loaded
// mentions and typing adjacent to a freshly-selected mention).
// If the span is stale (user edited inside it), remove it and record mentionStart
// so setMentionSpan can replace text correctly when the user picks a new mention.
val rangeSpans = spannable.getSpans(finalStart, finalEnd, EnrichedInputMentionSpan::class.java)
for (span in rangeSpans) {
val spanStart = spannable.getSpanStart(span)
val spanEnd = spannable.getSpanEnd(span)
val currentSpanText = spannable.subSequence(spanStart, spanEnd).toString()
if (currentSpanText == span.getText()) {
mentionHandler.endMention()
return
}
spannable.removeSpan(span)
mentionStart = spanStart
}

// Extract text without indicator
val text = spannable.subSequence(finalStart, finalEnd).toString().replaceFirst(indicator, "")

Expand Down