fix(web): create custom hook for useRef logic#666
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts repeated “latest value in a ref” patterns from EnrichedTextInput into a shared useStableRef hook for the web implementation.
Changes:
- Added a reusable
useStableRefhook that keeps a ref’s.currentsynchronized with the latest value via an effect. - Replaced multiple
useRef+useEffectblocks inEnrichedTextInputwithuseStableRef. - Adjusted memo/effect dependency lists where the new refs are referenced.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/web/useStableRef.ts | Introduces the new hook used to keep “latest” values in refs. |
| src/web/EnrichedTextInput.tsx | Refactors duplicated ref-update logic to use useStableRef for several props/callbacks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
exploIF
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes duplicated
useReflogic insideEnrichedTextInputby extracting it into a customuseStableRefhook.Test Plan
Run the example web app and verify that all enriched editor functionalities work properly.
Screenshots / Videos
n/a
Compatibility
Checklist