ci(docs): redeploy docs when figma/preview or web/Pulsar change#72
Merged
Conversation
The docs build bundles the standalone figma/preview app into the <iframe srcdoc> embed (via the prebuild step), and that app depends on web/Pulsar's pulsar-haptics build. But the deploy workflow only triggered on `docs/**`, so a change to the embed source (e.g. #70, which touched only figma/preview/src) merged to main without ever redeploying the docs — the live site kept serving the stale embed. Add figma/preview/**, web/Pulsar/** and the workflow file itself to the push path filter so embed-affecting changes deploy automatically. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removed comments about dependencies for docs deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Deploy Docs workflow only triggers on pushes touching
docs/**:But the docs build's
prebuildstep (docs/scripts/build-figma-preview.mjs) bundles the standalonefigma/previewapp into the<iframe srcdoc>embed, and that app depends onweb/Pulsar'spulsar-hapticsbuild. So a change to the embed source that doesn't also touchdocs/**merges tomainwithout ever redeploying the docs — the live site keeps serving a stale embed.This just bit us: #70 (the figma-preview host-bridge fix) changed only
figma/preview/src/**, merged cleanly, but never triggered a docs deploy, so production kept serving the old, broken embed.Fix
Add the embed-source paths (and the workflow file itself) to the
push.pathsfilter so embed-affecting changes auto-deploy:workflow_dispatchremains for manual runs.🤖 Generated with Claude Code