Make all elements of IssueOptions be Options#42
Open
Hrothen wants to merge 2 commits intosoftprops:masterfrom
Open
Make all elements of IssueOptions be Options#42Hrothen wants to merge 2 commits intosoftprops:masterfrom
Hrothen wants to merge 2 commits intosoftprops:masterfrom
Conversation
All parameters for the api endpoint are optional
Contributor
|
Hmm, this PR is quite old and a little bit stale too ( Also, I wonder if the objective here (making issue title and labels optional) could be approximated without breaking the API, i.e with an empty string and an empty Vec (which I don't think carry a distinct meaning). @Hrothen how interested are you in this change landing? |
Author
|
Not at all, this PR is 2 and a half years old, I've moved on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change, should this PR also update the project version?