Skip to content

Conversation

@billybonks
Copy link

This pr is still a work in progress, i made the changes for this pr machty/ember-concurrency#105.

  1. I haven't figure out how to access the application options for the command;

2.Still need to add documentation, but hoping to get your opinion in the mean time :);

@billybonks
Copy link
Author

@notmessenger just following up on this any thoughts ?

it is conflicting at the moment

@notmessenger
Copy link
Collaborator

@billybonks Sorry I haven't gotten around to taking a look at this yet - I've been busy.
Any chance you will be attending EmberConf this year? We could meet in person and hack at this :-)

@billybonks
Copy link
Author

hey sadly not, the change also needs to have some check to make sure it's building via ember build, otherwise it will cause a infinite loop build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants