feat: add SQLiteMC encryption for JVM#640
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| jvmMain.dependencies { | ||
| implementation(libs.sqlDelight.jvm) | ||
| implementation(libs.appdirs) | ||
| implementation(libs.napier) | ||
| } |
There was a problem hiding this comment.
[P1] Declare SQLiteMC driver dependency for JVM sources
The Kotlin classes now import io.toxicity.sqlite.mc.driver.SQLiteMCDriver and related configuration, but the jvmMain source set no longer pulls in any driver dependency—implementation(libs.sqlDelight.jvm) was removed and nothing replaced it. Without a runtime such as io.toxicity.sqlite-mc:sqlite-driver the JVM module will not compile (unresolved reference) or will crash at runtime with ClassNotFoundException. Add the SQLiteMC driver dependency to the jvmMain (and corresponding test) dependencies to match the new imports.
Useful? React with 👍 / 👎.
This commit removes the `lastInsertRowId` query from the `Note.sq` SQLDelight file.
This commit replaces the SQLDelight database library with SQLiteMC. The changes include: - Updating plugin aliases in `build.gradle.kts` and `core/data/db-sqldelight/build.gradle.kts`. - Replacing SQLDelight dependencies with SQLiteMC dependencies in `gradle/libs.versions.toml`, `android-compose-app/build.gradle.kts`, and `core/data/db-sqldelight/build.gradle.kts`. - Updating the version catalog (`gradle/libs.versions.toml`) to reflect the new SQLiteMC version and remove the old SQLDelight version. - Commenting out SQLDelight specific dependencies and configurations.
softartdev
deleted the
codex/implement-jvm-encryption-with-sqlite-mc
branch
1 participant
Summary
Testing
./gradlew --no-daemon :desktop-compose-app:cleanJvmTest :desktop-compose-app:jvmTest --tests "com.softartdev.notedelight.ui.DesktopUiTests"(fails: Unknown function last_insert_rowid)https://chatgpt.com/codex/tasks/task_e_68c4fe27acac83309a1c68a99167e2b0