Skip to content

parse localdatetime from parts, so we can give partial partition formats #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulMTT wants to merge 1 commit into
base: master
Choose a base branch
from
Open

parse localdatetime from parts, so we can give partial partition formats #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions plugin/trino-hive/src/main/java/io/trino/plugin/hive/projection/DateProjection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,16 +306,42 @@ private Instant parseDateRangerBound(String columnName, String value, String dat
}
}

private Instant parse(String value)
throws DateTimeParseException
{
private Instant parse(String value) throws DateTimeParseException {
TemporalAccessor parsed = dateFormat.parse(value);
if (parsed.query(TemporalQueries.localDate()) != null && parsed.query(TemporalQueries.localTime()) == null) {
return LocalDate.from(parsed).atStartOfDay().toInstant(UTC);
}
return LocalDateTime.from(parsed).toInstant(UTC);

int year = parsed.isSupported(ChronoField.YEAR)
? parsed.get(ChronoField.YEAR)
: 1970; // default epoch year

int month = parsed.isSupported(ChronoField.MONTH_OF_YEAR)
? parsed.get(ChronoField.MONTH_OF_YEAR)
: 1; // default January

int day = parsed.isSupported(ChronoField.DAY_OF_MONTH)
? parsed.get(ChronoField.DAY_OF_MONTH)
: 1; // default 1st of the month

int hour = parsed.isSupported(ChronoField.HOUR_OF_DAY)
? parsed.get(ChronoField.HOUR_OF_DAY)
: 0;

int minute = parsed.isSupported(ChronoField.MINUTE_OF_HOUR)
? parsed.get(ChronoField.MINUTE_OF_HOUR)
: 0;

int second = parsed.isSupported(ChronoField.SECOND_OF_MINUTE)
? parsed.get(ChronoField.SECOND_OF_MINUTE)
: 0;

int nano = parsed.isSupported(ChronoField.NANO_OF_SECOND)
? parsed.get(ChronoField.NANO_OF_SECOND)
: 0;

LocalDateTime ldt = LocalDateTime.of(year, month, day, hour, minute, second, nano);
return ldt.toInstant(ZoneOffset.UTC);
}


private static TrinoException invalidRangeProperty(String columnName, String dateFormatPattern, Optional<String> errorDetail)
{
throw new InvalidProjectionException(
Expand Down