Fix Windows extension feature detection.#4
Merged
Conversation
03af1f6 to
7b78849
Compare
7b78849 to
336f480
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
have_funcwith an actualrb_tracearg_instruction_sequencecall expression somkmfrejects missing header declarationstracervariable warning in the raw hook build path## Unreleasedrelease note for the Windows native extension build fixNotes
The Windows failure happened because probing the bare symbol can succeed when the symbol is linkable even if
ruby/debug.hdoes not declare it. The call-expression form fails on implicit declarations and still definesHAVE_RB_TRACEARG_INSTRUCTION_SEQUENCEwhen supported.ext/extconf.his generated bycreate_header; it is already ignored by.gitignoreand remains untracked.Validation
bundle exec bake testbundle exec rubocop