Resize coverage count arrays in one step#2
Merged
Conversation
samuel-williams-shopify
force-pushed
the
resize-counts-array-once
branch
from
f50db49 to
5d221fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the tracer's sparse line-number fallback path by resizing the counts array directly to the required length instead of pushing nil one element at a time. The normal path remains unchanged: preinitialized count arrays should already be large enough for executable lines.
rb_ary_push(Qnil)growth with a singlerb_ary_resize(..., line + 1)call.In the bounded-loop benchmark, this was effectively performance-neutral, which is expected because the resize path is rare in normal use.