Add priority heap benchmarks#183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmark/io/event/priority_heap.rbusingsus-fixtures-benchmark.push,concat,pop,heapify, anddelete_ifworkloads.Findings
A targeted native prototype patched the hot
PriorityHeapmethods from the extension. It improved plain Ruby in several heap-heavy paths, but YJIT generally performed better without adding C maintenance or load-order complexity. The native prototype is not included in this PR; this PR keeps the benchmark so future changes can be evaluated consistently.Local benchmark results from
benchmark/io/event/priority_heap.rb:pushin-orderpushreverse-orderconcatinto empty heappopheapifyafter delete/appenddelete_ifhalfConclusion: YJIT is the better optimization path for the current Ruby heap implementation. A native implementation does not look like a net win unless non-YJIT performance becomes important enough to justify maintaining duplicate heap logic in C.
Verification
BUNDLE_WITH='' bundle exec rubocop benchmark/io/event/priority_heap.rbBUNDLE_WITH='' bundle exec sus --verbose benchmark/io/event/priority_heap.rbBUNDLE_WITH='' bundle exec ruby --yjit -S sus --verbose benchmark/io/event/priority_heap.rb