feat: add snyk doctor extension

[CatalinSnyk]

Description

• Adding the initial Snyk Doctor extension/
• Registered under the local workflows and behind the experimental flag.

Checklist

• Tests added and all succeed (make test)
• Regenerated mocks, etc. (make generate)
• Linted (make lint)
• Test your changes work for the CLI - CLI PR
• Tracking CLI-1589 / CLI-1530

For the reviewer

I think we can keep this PR open and use this as a feature branch (meaning the other PRs from tickets from the same epic would merge into this instead of main), just to keep the feature scoped until we get more things going around it.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[robertolopezlopez]

some minor questions, one missing error check (maybe intended)

[robertolopezlopez]

approving waiting for those changes :)

[CatalinSnyk]

Thanks, I'm adding the tests now, just doing moving a few things around to get some dependency injections for the tests.

Also I'll keep the PR open for now, as I mentioned in the ticket and PR description - just to use it as a feature branch.

[CatalinSnyk]

Memory Inefficiency 🟠 [major]
The readDebugLog function returns a string, which forces a full copy of the log data from the initial []byte buffer. Subsequently, doctorEntryPoint converts this string back into a []byte when calling workflow.NewData, creating yet another copy. Snyk debug logs can be very large; this triple-buffering approach (byte slice -> string -> byte slice) significantly increases memory pressure and the risk of Out-Of-Memory (OOM) failures for no functional benefit. The code should pass []byte throughout.

Will be done later

[snyk-pr-review-bot]

PR Reviewer Guide 🔍

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Redundant Allocations 🟡 [minor] The readDebugLog function returns a string, which necessitates converting the []byte returned by os.ReadFile or io.ReadAll into a new string allocation (lines 76, 86). Subsequently, doctorEntryPoint converts this string back into a []byte at line 60 to pass it to workflow.NewData. Since Snyk debug logs can be extremely large, these redundant conversions significantly increase memory pressure by holding multiple copies of the data simultaneously. Returning []byte directly from readDebugLog would be more efficient. []byte(debugLog), workflow.WithLogger(logger), workflow.WithConfiguration(config), ) return []workflow.Data{outputData}, nil } func readDebugLog(stdin io.Reader, inputPath string) (string, error) { if inputPath != "" { content, err := os.ReadFile(inputPath) if err != nil { return "", cli.NewGeneralCLIFailureError( fmt.Sprintf("Could not read the debug log file at '%s'. Check that the path is correct and the file is readable.", inputPath), snyk_errors.WithCause(err), ) } return string(content), nil } content, err := io.ReadAll(stdin) if err != nil { return "", cli.NewGeneralCLIFailureError( "Could not read the debug log from standard input.", snyk_errors.WithCause(err), ) } return string(content), nil

📚 Repository Context Analyzed This review considered 12 relevant code sections from 11 files (average relevance: 0.85) pkg/local_workflows/connectivity_check_extension/connectivity_check_workflow.go (lines 1-97) pkg/local_workflows/ignore_workflow/ignore_workflow.go (lines 1-98) CONTRIBUTING.md (2 segments, lines 170-300) docs/extension-architecture-guide.md (lines 209-372) pkg/local_workflows/output_workflow/delayedfileopenwritecloser.go (lines 1-40) pkg/local_workflows/auth_workflow.go (lines 1-183) pkg/devtools/tree.go (lines 1-89) ... and 4 more file(s)