fix: Bump GAF to fix request body loss on 429 retry and connection leaks#6912
Open
danskmt wants to merge 1 commit into
Open
fix: Bump GAF to fix request body loss on 429 retry and connection leaks#6912danskmt wants to merge 1 commit into
danskmt wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
c91cc51 to
acdabd8
Compare
This comment has been minimized.
This comment has been minimized.
4 tasks
acdabd8 to
a99d5a6
Compare
This comment has been minimized.
This comment has been minimized.
a99d5a6 to
15f5f99
Compare
This comment has been minimized.
This comment has been minimized.
15f5f99 to
4152789
Compare
This comment has been minimized.
This comment has been minimized.
4152789 to
6f97f00
Compare
This comment has been minimized.
This comment has been minimized.
6f97f00 to
53ed3b7
Compare
This comment has been minimized.
This comment has been minimized.
53ed3b7 to
1459e32
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Bumps
go-application-frameworkto include fixes for CLI-1591:Request body preserved on retry — the retry middleware now always prepares a replayable body, so per-status-code retry overrides (e.g. 429 → 3 attempts) re-send the full body. Previously, body buffering was gated on
maxAttempts > 1, but the default is 1 — the 429 override to 3 attempts only kicks in after the first response, by which point the body was consumed and never buffered. This caused POST retries (e.g.snyk testdep graphs) to silently send empty bodies.Intermediate response bodies closed between retries — previously, each retry discarded the prior response without closing its body, leaking one TCP connection per retry. Now matches stdlib's
Client.dobehavior (drain + close).Orphaned transport body closed on permanent 503 —
getErrorListreads and replaces the response body for 503 responses but never closed the original. The transport body is now properly closed when it's been replaced.Where should the reviewer start?
cliv2/go.mod— GAF version bumpHow should this be manually tested?
snyk testagainst a project that triggers rate limiting (429)Risk assessment (Low | Medium | High)?
Medium — changes are in the retry middleware's core request/response lifecycle, affecting every network request that hits a retryable status code. While each fix is additive (buffering bodies that weren't buffered, closing bodies that weren't closed), the retry path is critical infrastructure and regressions could impact any CLI command that makes API calls.
What are the relevant tickets?
CLI-1591