Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,9 @@ workflows:
trusted-branch: main

- docs-only-check:
context: devex_cli_docker_hub
context:
- devex_cli_docker_hub
- go-private-modules
filters:
branches:
only:
Expand Down Expand Up @@ -629,6 +631,7 @@ workflows:
ignore:
- main
- '/release.*/'
- '/^docs\/.*/'

- test-legacy-tap:
context:
Expand Down Expand Up @@ -1473,7 +1476,7 @@ jobs:
command: |
CHANGED_FILES=$(git diff --name-only main)

# If this step fails, check if you need to add another extension,
# If this step fails, check if you need to add another extension,
# or indeed if this PR adds more than docs-related changes.
ALLOWED_DOCS_EXTENSIONS="(\.md|\.svg|\.jpg)$"

Expand All @@ -1487,6 +1490,19 @@ jobs:
fi
done
exit 0
- run:
name: Installing dependencies
command: npm ci --no-audit --no-progress

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--cache?

- install-go:
go_os: linux
go_target_os: linux
go_arch: amd64
base_url: << pipeline.parameters.go_download_base_url >>
extraction_path: '/tmp'
- setup-go-private-modules
- run:
name: Linting project
command: make lint
Comment on lines +1493 to +1505

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is c&p of lines 1452:1468 -> can you extract it to a job to reuse from both locations?


test-node:
executor: docker-amd64
Expand Down