Skip to content

feat(media): ✨ update api for media upload v2 #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MerleLiuKun merged 2 commits into from
May 9, 2025
Merged

feat(media): ✨ update api for media upload v2 #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e276ea
feat(media): :sparkles: update api for media upload v2
MerleLiuKun May 9, 2025
6b37602
feat(media): :white_check_mark: update tests for media upload v2
MerleLiuKun May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions pytwitter/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,6 @@ def upload_media_chunked_init_v2(
"""

args = {
"command": "INIT",
"total_bytes": total_bytes,
"media_type": media_type,
}
Expand All @@ -867,9 +866,9 @@ def upload_media_chunked_init_v2(
)

resp = self._request(
url=f"{self.BASE_URL_V2}/media/upload",
url=f"{self.BASE_URL_V2}/media/upload/initialize",
verb="POST",
data=args,
json=args,
)
data = self._parse_response(resp=resp)
if return_json:
Expand All @@ -893,13 +892,9 @@ def upload_media_chunked_append_v2(
:return: True if upload success.
"""
resp = self._request(
url=f"{self.BASE_URL_V2}/media/upload",
url=f"{self.BASE_URL_V2}/media/upload/{media_id}/append",
verb="POST",
params={
"command": "APPEND",
"media_id": media_id,
},
data={"segment_index": segment_index},
json={"segment_index": segment_index},
files={"media": media},
)
if resp.ok:
Expand All @@ -921,12 +916,8 @@ def upload_media_chunked_finalize_v2(
:return: Media upload response.
"""
resp = self._request(
url=f"{self.BASE_URL_V2}/media/upload",
url=f"{self.BASE_URL_V2}/media/upload/{media_id}/finalize",
verb="POST",
params={
"command": "FINALIZE",
"media_id": media_id,
},
)
data = self._parse_response(resp=resp)
if return_json:
Expand Down
8 changes: 4 additions & 4 deletions tests/apis/test_media_upload_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def test_media_upload_simple_v2(api_with_user, helpers):
def test_upload_media_chunked_init_v2(api_with_user, helpers):
responses.add(
responses.POST,
url="https://api.twitter.com/2/media/upload",
url="https://api.twitter.com/2/media/upload/initialize",
json=helpers.load_json_data(
"testdata/apis/media_upload_v2/upload_chunk_init_resp.json"
),
Expand Down Expand Up @@ -68,7 +68,7 @@ def test_upload_media_chunked_append_v2(api_with_user, helpers):

responses.add(
responses.POST,
url="https://api.twitter.com/2/media/upload",
url=f"https://api.twitter.com/2/media/upload/{media_id}/append",
)

with open("testdata/apis/media_upload/x-logo.png", "rb") as media:
Expand All @@ -88,7 +88,7 @@ def test_upload_media_chunked_append_v2(api_with_user, helpers):

responses.add(
responses.POST,
url="https://api.twitter.com/2/media/upload",
url=f"https://api.twitter.com/2/media/upload/{media_id}/append",
status=401,
json={"errors": [{"code": 32, "message": "Could not authenticate you."}]},
)
Expand All @@ -106,7 +106,7 @@ def test_upload_media_chunked_finalize_v2(api_with_user, helpers):

responses.add(
responses.POST,
url="https://api.twitter.com/2/media/upload",
url=f"https://api.twitter.com/2/media/upload/{media_id}/finalize",
json=helpers.load_json_data(
"testdata/apis/media_upload_v2/upload_chunk_finalize_resp.json"
),
Expand Down