chunked disconnect now throws InvalidChunkHeaders#578
Open
goertzenator wants to merge 3 commits into
Open
Conversation
Author
|
Some tests from conduit failing. Standby... |
Author
|
I think this PR is in good shape now. Some CI tests are failing, but it looks like dependency rot (correct me if I'm wrong) which has nothing to do with this PR. |
Collaborator
|
@goertzenator sorry for the delay, I'll try to get to this eventually. |
- Fixes issue snoyberg#168 - Was previously throwing `IncompleteHeaders` which is confusing and misleading. - Untangles readLine functions and call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 11 year old issue #168
We observed a
IncompleteHeadersexception after connecting to a streaming endpoint for an hour with a server initiated disconnect. That is rather misleading, so this PR changes that toInvalidChunkHeaders.The readline functions and call sites were also improved.
All tests pass.