Release v1.39.1#3806
Closed
sfc-gh-jrose wants to merge 7 commits intomainfrom
Closed
Conversation
Comment on lines
6
to
+7
| def test_importing_plugin_always_turns_on_auto_switch_backend(): | ||
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend.""" | ||
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off.""" |
Contributor
There was a problem hiding this comment.
The function name test_importing_plugin_always_turns_on_auto_switch_backend doesn't match the updated docstring which states that the plugin "always turns AutoSwitchBackend off". For consistency and clarity, consider renaming the function to test_importing_plugin_always_turns_off_auto_switch_backend to accurately reflect the behavior being tested.
Suggested change
| def test_importing_plugin_always_turns_on_auto_switch_backend(): | |
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend.""" | |
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off.""" | |
| def test_importing_plugin_always_turns_off_auto_switch_backend(): | |
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off.""" | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| #### New Features | ||
| #### Bug Fixes | ||
|
|
||
| - Added an experimental fix for a bug in schema query generation that could cause invalid sql to be genrated when using nested structured types. |
Contributor
There was a problem hiding this comment.
There's a typo in the changelog entry: "genrated" should be "generated".
Suggested change
| - Added an experimental fix for a bug in schema query generation that could cause invalid sql to be genrated when using nested structured types. | |
| - Added an experimental fix for a bug in schema query generation that could cause invalid sql to be generated when using nested structured types. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.