Extending the Snowpark Scala APIs#56
Open
sfc-gh-mrojas wants to merge 4 commits intosnowflakedb:mainfrom
Open
Conversation
sfc-gh-bli
reviewed
Oct 12, 2023
sfc-gh-bli
reviewed
Oct 12, 2023
sfc-gh-bli
reviewed
Oct 12, 2023
sfc-gh-bli
reviewed
Oct 12, 2023
sfc-gh-bli
requested changes
Oct 12, 2023
Collaborator
sfc-gh-bli
left a comment
There was a problem hiding this comment.
- When adding new functions please update Scala and Java API together
- Please add tests for any new codes.
@sfc-gh-bli are there any example of the recommended practice on how we can create and run new tests? are there any contribution steps documented that we can follow ? |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #802269
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Replace this with a short description of how your code change solves the related issue.
Pre-review checklist
(For Snowflake employees)
This PR will address these APIs:
Adding the following methods:
selectthat accepts SQL expressions.nrows.nrows* int
* String
* Float
* double
* booelan
* int
* String
* float
* double
* boolean
* int
* String
* float
* double
* boolean