Update functions.scala#130
Open
sfc-gh-sjayabalan wants to merge 21 commits intosnowflakedb:mainfrom
Open
Conversation
Added functions.json_tuple, functions.cbrt, functions.from_json, functions.date_sub.
Added functions.json_tuple functions.cbrt functions.from_json functions.date_sub
Modified styling
Adjusted based scala style error
Adjusted to scala style
Adjusted scala style
Adjusting based on scala checker
Adjusted scala checker
| * |CR |5 |Jose |29 |Mobilize | | ||
| * ------------------------------------------------- | ||
| * </pre> | ||
| * @since 1.10.0 |
Collaborator
There was a problem hiding this comment.
is this version number accurate?
Added test cases for cbrt
Added testcases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functions.json_tuple,
functions.cbrt,
functions.from_json,
functions.date_sub.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fill out the following pre-review checklist:
Added below functions to functions.scala
functions.json_tuple | JSON_EXTRACT_PATH_TEXT
functions.cbrt | CBRT
functions.from_json | TRY_PARSE_JSO
functions.date_sub | implements equivalent to spark
Please describe how your code solves the related issue.
Replace this with a short description of how your code change solves the related issue.
Pre-review checklist
(For Snowflake employees)