-
Notifications
You must be signed in to change notification settings - Fork 15
fix: pin miniforge to working version 25.9.1
#49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Basically, this is only until this problem's fix (which already seems to exist), is either patched and/or released in `conda-libmamba-solver`, probably via `conda` itself: conda/conda-libmamba-solver#798
📝 WalkthroughWalkthroughReplaced Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I converted this to a draft, for now, as a rebuild of the If this fixes it, I'll close this pull request and delete it. If it doesn't, I'll investigate further. |
|
if this get's fixed upstream, we don't need to bother about fixing it in other ways anymore. @dlaehnemann we had already a test PR + discussion going at #47 #48 |
|
Ah, thanks for the pointer. This is the one place where I didn't explicitly search for any discussion of this issue, even though I obviously should have. |
|
Hi David, the issue persists even after merging the upstream PR, but that's no wonder because the current conda release 25.11.0 is the same as before. Do you know how often conda gets a new release? Maybe we do merge this PR for now until a new conda version is released. |
|
OK, with regard to our discussion in the other issue, I updated the code comment in this pull request and this is ready for review. |
Basically, this is only until this problem's fix is released in
conda-libmamba-solver, probably via theminiforgeinstaller: conda/constructor#1135The issue that I am seeing, which this pinning should solve, is this error upon trying to re-install miniforge a second time during a GitHub Action run:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.