Fixed bug with scrolling/key press to move between frames#54
Open
ingridtv wants to merge 1 commit intosmistad:masterfrom
Open
Fixed bug with scrolling/key press to move between frames#54ingridtv wants to merge 1 commit intosmistad:masterfrom
ingridtv wants to merge 1 commit intosmistad:masterfrom
Conversation
I noticed that when hovering over the canvas and scrolling, the current frame number incremented/decremented beyond the range of frames (for me, below 0 and above the total number of frames). The same bug happened with key left/right presses. I added an if-statement in annotationweb.js that seems to fix the problem. (cherry picked from commit 5e25cf9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when hovering over the canvas and scrolling, the current frame number incremented/decremented beyond the range of frames (for me, below 0 and above the total number of frames). The same bug happened with key left/right presses. The canvas keeps displaying the first/last frame in the sequence, but the browser console gives an error message:
I added if statements to the calls to
goToFrame()in annotationweb.js that seems to fix the problem.(cherry picked from commit 5e25cf9)