Allow/Deny inline constants#585
Open
artcs wants to merge 5 commits intosmarty-php:masterfrom
artcs:inline_constants
Open
Allow/Deny inline constants#585artcs wants to merge 5 commits intosmarty-php:masterfrom artcs:inline_constants
artcs wants to merge 5 commits intosmarty-php:masterfrom
artcs:inline_constants
Conversation
Contributor
|
Missing tests. |
Author
|
I found function calls like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding var
$allow_inline_constantsto SmartyClass and using it in templateparser. This way you can globally deny use of inline constants without$smarty.const.prefix to avoid various ambiguities. Just set$Smarty->allow_inline_constants = false. Defaults to true for backwards compatibility.Closes #554