[PLEX - 2742] - local cre + simple latest block e2e test#23015
[PLEX - 2742] - local cre + simple latest block e2e test#23015ilija42 wants to merge 18 commits into
Conversation
ilija42
force-pushed
the
PLEX-2742-local-cre-stellar
branch
from
d300103 to
6450f8a
Compare
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
I see you updated files related to
|
|
✅ No conflicts with other open PRs targeting |
|
|
ilija42
requested review from
AmrMohamedRezk,
KodeyThomas,
carte7000,
makramkd,
matYang,
ogtownsend and
tt-cll
product-security-plaid-production
Bot
requested review from
DimitriosNaikopoulos,
MStreet3,
Tofel,
kalverra,
se3000 and
vyzaldysanchez
and removed request for
MStreet3
ilija42
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 680c304099
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 619927b311
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local_image = "job-distributor:0.28.0" | ||
| ecr_image = "{{.MAIN_ECR}}/job-distributor:0.28.0" |
There was a problem hiding this comment.
When a developer runs go run . env setup from a clean Docker cache, this now only builds/pulls job-distributor:0.28.0, but the CRE TOML files still ask the environment to start job-distributor:0.22.1 (for example the new workflow-gateway-don-stellar.toml does so). The environment startup path checks that in.JD.Image exists locally and tells users to run setup, so setup no longer prepares the image that env restart validates and the local CRE start fails unless the old tag happens to be cached; either update the configs to 0.28.0 or tag/pull 0.22.1 as part of setup.
Useful? React with 👍 / 👎.
|
1 participant
Requires
Supports