Updates to error reporting checks between FQ versions#21757
Updates to error reporting checks between FQ versions#21757
Conversation
simsonraj
requested review from
0xAustinWang,
KodeyThomas,
asoliman92,
makramkd,
matYang,
mateusz-sekara and
winder
|
👋 simsonraj, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR updates FeeQuoter cross-version validation to better align reported errors with the business “expected” fee values (so v2.0 misconfigs are caught even if incorrect values were propagated forward from v1.6).
Changes:
- Adjusts v1.6 dest-chain validation to always enforce topology-derived
NetworkFeeUSDCents/DefaultTokenFeeUSDCentsand treatGasMultiplierWeiPerEthas a deploy-constant. - Adjusts v2.0 dest-chain validation by splitting “deploy-constants” vs “topology” checks and simplifying v1.5/v1.6 cross-version mappings (removing fee-field cross-checks).
- Updates cross-version tests to use topology/deploy constants rather than v1.5-derived values for the relevant fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| deployment/ccip/shared/stateview/evm/validate_feequoter.go | Updates v1.6/v2.0 dest-chain validations to enforce expected fee fields more consistently across versions. |
| deployment/ccip/shared/stateview/evm/validate_feequoter_test.go | Updates cross-version test configs to match the new topology/deploy-constant validation expectations. |
|
re-orgd validations to make it more clear and aligns with the business validations to ensure 2.0 errors captured even when wrong values are propagated from 1.6 - to align with billing expectations