[Chore] Re-enable E2E tests#401
Merged
Merged
Conversation
Collaborator
Author
|
We need to ignore the failure in Validate Go Mod Files as we are currently using a commit hash from a PR in repos like MCMS and CLDF. Once the corresponding PRs in other repos are merged, we will circle back and update deps refs. |
FelixFan1992
previously approved these changes
Jun 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables system integration (E2E) and deployment/ops tests in CI by migrating test/client wiring to the Sui gRPC client and bumping related dependencies, plus extending the bindings mapping layer to include gRPC event data.
Changes:
- Re-enabled CI jobs for operations and system integration tests (removed
if: falseguards). - Migrated multiple integration/deployment test utilities from JSON-RPC (
sui.ISuiAPI) to the relayer gRPC client (SuiPTBClient/BindingsClient) and updated local gRPC target usage. - Updated bindings gRPC response mapping (including events) and bumped module dependencies across
deployment/,integration-tests/, andscripts/.
Reviewed changes
Copilot reviewed 20 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/go.mod | Bumps indirect deps for scripts module; uses local chainlink-sui via replace. |
| scripts/go.sum | Updated checksums for bumped script dependencies. |
| relayer/txm/broadcaster.go | Reduces broadcast logging payload. |
| relayer/testutils/node.go | Adjusts port-detection logic when waiting for node connectivity. |
| relayer/monitor/metrics.go | Adds RPC transaction duration gauge metric. |
| relayer/client/grpc_client.go | Removes debug logs; exports event hydration helper and updates call sites. |
| integration-tests/onramp/environment/token_pools.go | Switches environment helpers to accept the gRPC client interface. |
| integration-tests/onramp/environment/setup.go | Sets required env earlier; switches local target to gRPC address. |
| integration-tests/onramp/ccip_onramp_test.go | Uses local gRPC target; removes JSON-RPC event querying and adds skip. |
| integration-tests/mcms/common.go | Switches suite client type to gRPC client interface; minor formatting cleanup. |
| integration-tests/mcms/ccip_test.go | Migrates object reads to bind.ReadObject helper. |
| integration-tests/go.mod | Bumps deployments framework + mcms; uses local chainlink-sui replace version. |
| integration-tests/go.sum | Updated checksums for bumped integration-test dependencies. |
| integration-tests/deploy/common.go | Migrates object existence checks to bind.ReadObject and gRPC client. |
| go.md | Updates dependency graph to include chainlink-ccip/chains/evm links. |
| deployment/utils/mcms.go | Changes proposal generator input client from JSON-RPC to bindings-oriented gRPC interface. |
| deployment/ops/mcms/op_proposal_generate_test.go | Updates mocks to use gRPC-style client methods and objects. |
| deployment/go.mod | Bumps deployments framework + mcms and related indirect deps. |
| deployment/go.sum | Updated checksums for bumped deployment dependencies. |
| bindings/tests/testenv/testenv.go | Returns SuiPTBClient from the test environment and updates PTB client creation signature. |
| bindings/bind/publish.go | Updates coin type matching to padded address format. |
| bindings/bind/grpc_response.go | Extends execute response mapping/read masks to include events. |
| .github/workflows/pull-request-develop.yml | Re-enables operations + system integration tests in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* NONEVM-5191: implement receiver abi check * fix * fix * fix lint * update * addres feedback * fix * update
FelixFan1992
previously approved these changes
Jun 8, 2026
…ests (#394) * NONEVM-5191: implement receiver abi check * make broken receiver not blocking relayer and add more tests * fix * fix * address feedback and issues * fix * fix lint * update * addres feedback * fix * update * fix lint * fix * more tests * fix tests * fix * fix tests * clean up * fix lint --------- Co-authored-by: Faisal <faisal.altameemi@smartcontract.com>
* nonevm-5255: check for errors before memory allocation * address feedback * more checks * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Faisal <faisal.altameemi@smartcontract.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* NONEVM-5258: billing for Sui => Sui * fix tests * fi * fix
|
Hello, @faisal-chainlink! 👋
|
FelixFan1992
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR re-enables the system integration (E2E scenarios) and deployment Ops tests in CI workflows. This includes deployments and MCMS tests as the primary checks.
Issue ticket number and link
NONEVM-5226
Describe highly relevant files or code snippets that are critical in the review
The primary change is that the deployment and MCMS related code now references a commit hash in the corresponding repos with the updated gRPC client setup. It also extends the mapping layer (in bindings).
Are there other PRs that should be merged first?
No, but this PR references 2 dependencies (MCMS and CLDF) using commit hashes for each corresponding PR: