NONEVM-4809: fast curse#400
Open
FelixFan1992 wants to merge 71 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a “fast curse” path for ccip::rmn_remote by adding a new CurserCap capability that allows curse-only operations without granting OwnerCap authority, along with MCMS entrypoints to use and bootstrap this capability via separate (fast/slow) MCMS registries.
Changes:
- Add
CurserCapplus newcurse_with_curser_cap/curse_multiple_with_curser_capfunctions and shared curse insertion logic inccip::rmn_remote. - Add fast-MCMS callbacks that curse using a
CurserCap, and slow-MCMS bootstrap wrappers to mint/register the cap into a fast registry. - Extend Move unit tests and regenerate Go bindings to cover/consume the new public APIs.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
contracts/ccip/ccip/sources/rmn_remote.move |
Adds CurserCap capability, new curse entrypoints using it, and MCMS callbacks/wrappers for fast-curse flows. |
contracts/ccip/ccip/tests/rmn_remote_tests.move |
Adds direct and MCMS-based unit tests for the CurserCap fast-curse flows and bootstrap procedures. |
bindings/generated/ccip/ccip/rmn_remote/rmn_remote.go |
Regenerates bindings to include new CurserCap-related functions and types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* nonevm-5255: check for errors before memory allocation * address feedback * more checks * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Faisal <faisal.altameemi@smartcontract.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* NONEVM-5258: billing for Sui => Sui * fix tests * fi * fix
Comment on lines
+196
to
+199
| #[test_only] | ||
| public fun test_init(ctx: &mut TxContext) { | ||
| init(MCMS_DEPLOYER {}, ctx); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.