Conversation
Contributor
silaslenihan
left a comment
silaslenihan
left a comment
There was a problem hiding this comment.
Assuming we are killing write target because products will jump directly to mainline CRE
| if err != nil { | ||
| return nil, fmt.Errorf("invalid transaction payload: %w", err) | ||
| } | ||
| // remove dummy signatures |
Contributor
There was a problem hiding this comment.
nit: could you maybe just add a little more on where these dummy signatures come from?
| txBytes := obj.GetBinary() | ||
|
|
||
| txJSON, jerr := json.Marshal(obj) | ||
| txJSON, _ := json.Marshal(obj) |
amit-momin
reviewed
Jan 28, 2026
amit-momin
reviewed
Jan 28, 2026
amit-momin
reviewed
Jan 28, 2026
amit-momin
previously approved these changes
Jan 29, 2026
| Config() config.Config | ||
| } | ||
|
|
||
| func New(chain Chain, reader client.Reader, txm Txm, chainInfo commontypes.ChainInfo, lggr logger.Logger) (capabilities.ExecutableCapability, error) { |
Collaborator
There was a problem hiding this comment.
Are we sure that WriteTarget is not used?
| } | ||
| if c.cfg.Workflow.IsEnabled() { | ||
| c.lggr.Debug("Starting LogPoller") | ||
| startAll = append(startAll, c.lp) |
Collaborator
There was a problem hiding this comment.
Hm, I wonder how CCIP works without starting the LP
Contributor
Author
There was a problem hiding this comment.
They spin up logPoller during ChainReader creation
| } | ||
|
|
||
| return &commonsol.SubmitTransactionReply{Status: txStatus, Signature: commonsol.Signature(signature), IdempotencyKey: transactionID}, nil | ||
| return &commonsol.SubmitTransactionReply{Status: txStatus, IdempotencyKey: transactionID}, nil |
Collaborator
There was a problem hiding this comment.
Isn't it a breaking change that we no longer return the transaction signature?
Are we sure that noone else uses this method?
Contributor
Author
There was a problem hiding this comment.
- The only consumer of SolanaService currently is solana capability, so noone uses this method
- TxManager().GetTransactionSig returns only signatures for pending transactions, here call always returns an error since at this point transaction is finalized
- Solana capability doesn't rely on signature from txm and instead retreives signatures from Logs
However, having signature in reply is potentially missleading so I would either alter GetTransactionSig to support returning signatures for finalized tx (with some cleanup interval) or removed Signature from response. Gonna do this in a follow up PR
|
dhaidashenko
approved these changes
Feb 2, 2026
dhaidashenko
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supports:
Contracts are carried out in a separate go module in order to improve artifacts resolution logic in core