Skip to content

pkg/settings: add per-chain overridable EVM.GasLimit #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmank88 merged 1 commit into from
Jan 6, 2026
Merged

pkg/settings: add per-chain overridable EVM.GasLimit #1757

jmank88 merged 1 commit into from
Jan 6, 2026

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 5, 2026 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Jan 5, 2026 •
edited
Loading

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (2)

pkg/settings/limits (2)
  • MakeBoundLimiter — Type changed:
func(
  Factory, 
  - github.com/smartcontractkit/chainlink-common/pkg/settings.Setting[N]
  + github.com/smartcontractkit/chainlink-common/pkg/settings.IsSetting[N]
)
(BoundLimiter[N], error)
  • MakeGateLimiter — Type changed:
func(
  Factory, 
  - github.com/smartcontractkit/chainlink-common/pkg/settings.SettingMap[bool]
  + github.com/smartcontractkit/chainlink-common/pkg/settings.IsSetting[bool]
)
(GateLimiter, error)

📄 View full apidiff report

@jmank88 jmank88 requested a review from dhaidashenko January 5, 2026 22:49
jmank88
jmank88 commented Jan 5, 2026
View reviewed changes
pkg/settings/map.go
}

func (s *SettingMap[T]) Subscribe(ctx context.Context, registry Registry) (<-chan Update[T], func()) {
//TODO subscribe to Values & Default
Copy link
Contributor Author

@jmank88 jmank88 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deferred.

jmank88
jmank88 commented Jan 5, 2026
View reviewed changes
pkg/settings/settings.go
SubscribeScoped(ctx context.Context, scope Scope, key string) (updates <-chan Update[string], stop func())
}

//TODO use this everywhere
Copy link
Contributor Author

@jmank88 jmank88 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no harm in doing this now.

Copy link
Contributor Author

@jmank88 jmank88 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah but it would take a bit extra effort, so can defer

@jmank88 jmank88 force-pushed the PLEX-2367-per-chain-gas-limit branch from 243d506 to bb15e1b Compare January 5, 2026 22:54
@jmank88 jmank88 requested a review from pavel-raykov January 5, 2026 22:55
@jmank88 jmank88 requested a review from amit-momin January 6, 2026 14:09
@jmank88 jmank88 marked this pull request as ready for review January 6, 2026 14:09
@jmank88 jmank88 requested a review from a team as a code owner January 6, 2026 14:09
jmank88
jmank88 commented Jan 6, 2026
View reviewed changes
pkg/settings/settings.go
Comment on lines +34 to +36
type IsSetting[T any] interface {
GetSpec() SettingSpec[T]
}
Copy link
Contributor Author

@jmank88 jmank88 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra indirection keeps the API compatible, where we are passing values instead of pointers.

@jmank88 jmank88 requested a review from bolekk January 6, 2026 15:56
@jmank88 jmank88 added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit bf2f64d Jan 6, 2026
34 of 36 checks passed
@jmank88 jmank88 deleted the PLEX-2367-per-chain-gas-limit branch January 6, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amit-momin amit-momin amit-momin approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@dhaidashenko dhaidashenko Awaiting requested review from dhaidashenko

@mchain0 mchain0 Awaiting requested review from mchain0

@bolekk bolekk Awaiting requested review from bolekk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmank88 @amit-momin @pavel-raykov