-
Notifications
You must be signed in to change notification settings - Fork 25
INFOPLAT 3099 chip ingress batching #1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
hendoxc
commented
Jan 5, 2026
- Adds chipingress batching client
- Adds unit-tests
|
👋 hendoxc, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a batching client for chipingress that collects CloudEvent messages and sends them in batches based on configurable size and timeout triggers. The implementation provides non-blocking message queuing with configurable concurrency control.
Key changes:
- Implements a
BatchClientwith configurable batch size, timeout, buffer size, and concurrency limits - Provides asynchronous batch processing with proper context cancellation and shutdown handling
- Includes comprehensive unit tests covering batch triggers, edge cases, and concurrent operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/chipingress/batch/client.go | Implements the core BatchClient with Start/Stop lifecycle, message queuing, and batch sending logic with configurable options |
| pkg/chipingress/batch/client_test.go | Provides comprehensive test coverage for client initialization, message queuing, batch sending, and various trigger scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ API Diff Results - No breaking changes |
FIxes test
e705b9f to
703498f
Compare