trigger error generator changes #1753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 ettec, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the trigger error handling mechanism by replacing standard Go error types with custom caperrors.Error types for trigger registration and unregistration methods. The changes involve updating both the generated code and the templates that produce it to use the new error type while maintaining compatibility with existing interfaces through adapter functions.
- Updated protoc-gen-go version from v1.36.8 to v1.36.10
- Changed trigger registration/unregistration method signatures to return
caperrors.Errorinstead oferror - Added adapter functions to bridge between the new
caperrors.Errorinterface and the existingerrorinterface expected bycapabilities.RegisterTrigger
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/capabilities/v2/triggers/cron/trigger.pb.go | Updated protoc-gen-go version comment |
| pkg/capabilities/v2/triggers/cron/server/trigger_server_gen.go | Generated code reflecting template changes with new error types and adapter functions |
| pkg/capabilities/v2/protoc/pkg/templates/server.go.tmpl | Template updated to generate trigger methods with caperrors.Error return types and adapter functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{ $hasTriggers = true }} | ||
| Register{{.GoName}}(ctx context.Context, triggerID string, metadata capabilities.RequestMetadata, input *{{ImportAlias .Input.GoIdent.GoImportPath}}.{{.Input.GoIdent.GoName}}) (<- chan capabilities.TriggerAndId[*{{ImportAlias .Output.GoIdent.GoImportPath}}.{{.Output.GoIdent.GoName}}], error) | ||
| Unregister{{.GoName}}(ctx context.Context, triggerID string, metadata capabilities.RequestMetadata, input *{{ImportAlias .Input.GoIdent.GoImportPath}}.{{.Input.GoIdent.GoName}}) error | ||
| Register{{.GoName}}(ctx context.Context, triggerID string, metadata capabilities.RequestMetadata, input *{{ImportAlias .Input.GoIdent.GoImportPath}}.{{.Input.GoIdent.GoName}}) (<- chan capabilities.TriggerAndId[*{{ImportAlias .Output.GoIdent.GoImportPath}}.{{.Output.GoIdent.GoName}}], caperrors.Error) |
There was a problem hiding this comment.
The template references caperrors but doesn't include the import statement. Ensure the generated code includes caperrors \"github.com/smartcontractkit/chainlink-common/pkg/capabilities/errors\" in the imports section of the template.
|
product-security-plaid-production
bot
requested review from
fernandezlautaro,
jmank88 and
nolag
Contributor
Author
|
Pusehd f |
Contributor
Author
|
from wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkin work done so far on trigger error changes.