Skip to content

[CRE] Log more details of observations in DONTime plugin #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bolekk merged 1 commit into from
Jan 5, 2026
+28 −8
Merged

[CRE] Log more details of observations in DONTime plugin #1750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions pkg/workflows/dontime/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ import (
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/types/known/structpb"

"github.com/smartcontractkit/chainlink-common/pkg/logger"
"github.com/smartcontractkit/chainlink-common/pkg/workflows/dontime/pb"
"github.com/smartcontractkit/libocr/commontypes"
"github.com/smartcontractkit/libocr/offchainreporting2plus/ocr3types"
"github.com/smartcontractkit/libocr/offchainreporting2plus/types"
"github.com/smartcontractkit/libocr/quorumhelper"

"github.com/smartcontractkit/chainlink-common/pkg/logger"
"github.com/smartcontractkit/chainlink-common/pkg/workflows/dontime/pb"
)

type Plugin struct {
Expand Down Expand Up @@ -121,7 +122,12 @@ func (p *Plugin) ObservationQuorum(_ context.Context, _ ocr3types.OutcomeContext

func (p *Plugin) Outcome(_ context.Context, outctx ocr3types.OutcomeContext, _ types.Query, aos []types.AttributedObservation) (ocr3types.Outcome, error) {
observationCounts := map[string]int64{} // counts how many nodes reported where a new DON timestamp might be needed
var times []int64
type timestampNodePair struct {
Timestamp int64
NodeID int
OffsetFromMedian int64
}
var timestampNodePairs []timestampNodePair

prevOutcome := &pb.Outcome{}
if err := proto.Unmarshal(outctx.PreviousOutcome, prevOutcome); err != nil {
Expand All @@ -131,7 +137,7 @@ func (p *Plugin) Outcome(_ context.Context, outctx ocr3types.OutcomeContext, _ t
prevOutcome.ObservedDonTimes = make(map[string]*pb.ObservedDonTimes)
}

for _, ao := range aos {
for idx, ao := range aos {
observation := &pb.Observation{}
if err := proto.Unmarshal(ao.Observation, observation); err != nil {
p.lggr.Errorf("failed to unmarshal observation in Outcome phase")
Expand All @@ -153,12 +159,26 @@ func (p *Plugin) Outcome(_ context.Context, outctx ocr3types.OutcomeContext, _ t
}
}

times = append(times, observation.Timestamp)
timestampNodePairs = append(timestampNodePairs, timestampNodePair{Timestamp: observation.Timestamp, NodeID: idx})
}
if len(timestampNodePairs) == 0 {
return nil, errors.New("no observation contains a valid timestamp")
}

p.lggr.Debugw("Observed Node Timestamps", "timestamps", times)
slices.Sort(times)
donTime := times[len(times)/2]
slices.SortFunc(timestampNodePairs, func(a, b timestampNodePair) int {
return int(a.Timestamp - b.Timestamp)
})
donTime := timestampNodePairs[len(timestampNodePairs)/2].Timestamp
for i := range timestampNodePairs {
timestampNodePairs[i].OffsetFromMedian = timestampNodePairs[i].Timestamp - donTime
}
p.lggr.Debugw("Observed Node Timestamps",
"timestampNodePairs", timestampNodePairs,
"median", donTime,
"collectedDataPoints", len(timestampNodePairs),
"minOffsetFromMedian", timestampNodePairs[0].OffsetFromMedian,
"maxOffsetFromMedian", timestampNodePairs[len(timestampNodePairs)-1].OffsetFromMedian,
)

outcome := prevOutcome

Expand Down
Loading