adding grpc workflow metadata source client and related types #1749

patrickhuie19 · 2026-01-02T23:17:39Z

Supporting Private Workflow Registry

This change is part of a series of changes to allow the workflow engine to pull workflows from metadata sources other than the WorkflowRegistry.

For broader context, check out https://docs.google.com/document/d/1K5lLtczMe_HyrLTbdLNmb_jxj40lPCmMZW4OBjn7K5U/edit?tab=t.t17fuwqoj0w9#bookmark=id.i3vs01f9lvvr

For the workflow engine specific changes, this diagram is most relevant:

Series

[In-review] chainlink-protos: smartcontractkit/chainlink-protos#255
[In-review] chainlink-common: #1749
[In-review] chainlink: smartcontractkit/chainlink#20708

Changes specific to chainlink-common

Establish the grpc source client for consumption in the workflow engine
Add a server side token parser to use in the grpc workflow metadata source + billing + storage service clients

github-actions · 2026-01-02T23:18:39Z

✅ API Diff Results - No breaking changes

📄 View full apidiff report

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite	Current: `6872c33`	Previous: `6c0b1c8`	Ratio
`BenchmarkKeystore_Sign/nop/in-process`	`770.9` ns/op	`358.4` ns/op	`2.15`

This comment was automatically generated by workflow using github-action-benchmark.

cedric-cordenier · 2026-01-05T12:03:09Z

pkg/workflows/grpcsource/client.go

+// start is the pagination offset (0-indexed).
+// limit is the maximum number of workflows to return per page.
+// Returns workflows, head, hasMore flag indicating if more pages exist, and error.
+func (c *Client) ListWorkflowMetadata(ctx context.Context, families []string, start, limit int64) ([]*pb.WorkflowMetadata, *pb.Head, bool, error) {


@patrickhuie19 Are you sure you want to put this logic in a separate repository? That seems like a heavy price to pay -- isn't the only consumer of this client going to be in core?

Thanks cedric, good q: the benefits I'm seeing: it allows us to easily inject the client into smoke tests within the chainlink repo and eventually the centralized component to deploy in. We follow this pattern for the storage and billing clients.

bolekk · 2026-01-06T03:35:23Z

pkg/workflows/privateregistry/types.go

+	AddWorkflow(ctx context.Context, workflow *WorkflowRegistration) error
+
+	// UpdateWorkflow updates the workflow's status configuration
+	// This is idempotent - calling with the same config multiple times has the same effect


nit: I think this goes without saying, especially when looking at WorkflowStatusConfig struct

bolekk · 2026-01-06T03:42:36Z

pkg/workflows/grpcsource/client.go

+		return nil, fmt.Errorf("failed to create JWT: %w", err)
+	}
+
+	return metadata.AppendToOutgoingContext(ctx, "authorization", "Bearer "+jwtToken), nil


TIL: My gut reaction was that we don't need the "Bearer" prefix in gRPC as it is only specific to HTTP. But a quick Google search said otherwise :)

bolekk · 2026-01-06T03:42:49Z

pkg/workflows/grpcsource/client.go

+		return nil, fmt.Errorf("failed to create JWT: %w", err)
+	}
+
+	return metadata.AppendToOutgoingContext(ctx, "authorization", "Bearer "+jwtToken), nil


nit: put those in consts?

bolekk · 2026-01-06T03:43:25Z

pkg/nodeauth/grpc/token_extractor.go

+	// AuthorizationHeader is the lowercase header key for authorization
+	AuthorizationHeader = "authorization"
+	// BearerPrefix is the prefix for Bearer tokens
+	BearerPrefix = "Bearer "


nit: are you sure you want the space included in the constant?

That is defined from the protocol definition, so yes I think it's desirable - what downside are you seeing?

adding grpc workflow metadata source client and related types

6c0b1c8

patrickhuie19 temporarily deployed to integration January 2, 2026 23:17 — with GitHub Actions Inactive

downgrading dependencies to keep diff clean

fdd5f60

patrickhuie19 temporarily deployed to integration January 3, 2026 04:15 — with GitHub Actions Inactive

This was referenced Jan 3, 2026

adding protos for private workflow registry source smartcontractkit/chainlink-protos#255

Merged

Supporting Private Workflow Registry smartcontractkit/chainlink#20708

Open

patrickhuie19 marked this pull request as ready for review January 5, 2026 00:05

patrickhuie19 requested review from a team as code owners January 5, 2026 00:05

product-security-plaid-production bot requested review from MStreet3 and krehermann January 5, 2026 00:05

mchain0 previously approved these changes Jan 5, 2026

View reviewed changes

mchain0 temporarily deployed to integration January 5, 2026 07:14 — with GitHub Actions Inactive

github-actions bot reviewed Jan 5, 2026

View reviewed changes

cedric-cordenier reviewed Jan 5, 2026

View reviewed changes

updating chainlink-protos

e53998d

patrickhuie19 dismissed mchain0’s stale review via e53998d January 6, 2026 00:37

patrickhuie19 force-pushed the feat/private-workflow-registry branch from d2e620e to e53998d Compare January 6, 2026 00:37

patrickhuie19 had a problem deploying to integration January 6, 2026 00:37 — with GitHub Actions Error

Merge branch 'main' into feat/private-workflow-registry

76174c9

patrickhuie19 temporarily deployed to integration January 6, 2026 00:38 — with GitHub Actions Inactive

bolekk previously approved these changes Jan 6, 2026

View reviewed changes

bumping protos

f397286

patrickhuie19 dismissed bolekk’s stale review via f397286 January 6, 2026 05:29

patrickhuie19 temporarily deployed to integration January 6, 2026 05:29 — with GitHub Actions Inactive

bumping protos + PR feedback

6872c33

patrickhuie19 requested review from bolekk, cedric-cordenier and mchain0 January 6, 2026 05:37

patrickhuie19 temporarily deployed to integration January 6, 2026 05:37 — with GitHub Actions Inactive

cedric-cordenier approved these changes Jan 6, 2026

View reviewed changes

george-dorin approved these changes Jan 6, 2026

View reviewed changes

patrickhuie19 added this pull request to the merge queue Jan 6, 2026

Merged via the queue into main with commit e801ad1 Jan 6, 2026
34 of 36 checks passed

patrickhuie19 deleted the feat/private-workflow-registry branch January 6, 2026 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adding grpc workflow metadata source client and related types #1749

adding grpc workflow metadata source client and related types #1749

patrickhuie19 commented Jan 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 2, 2026 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

cedric-cordenier Jan 5, 2026

Uh oh!

patrickhuie19 Jan 5, 2026

Uh oh!

bolekk Jan 6, 2026

Uh oh!

bolekk Jan 6, 2026

Uh oh!

bolekk Jan 6, 2026

Uh oh!

bolekk Jan 6, 2026

Uh oh!

patrickhuie19 Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adding grpc workflow metadata source client and related types #1749

adding grpc workflow metadata source client and related types #1749

Conversation

patrickhuie19 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Supporting Private Workflow Registry

Series

Changes specific to chainlink-common

Uh oh!

github-actions bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ API Diff Results - No breaking changes

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

cedric-cordenier Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

patrickhuie19 Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

bolekk Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

bolekk Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

bolekk Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

bolekk Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

patrickhuie19 Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

patrickhuie19 commented Jan 2, 2026 •

edited

Loading

github-actions bot commented Jan 2, 2026 •

edited

Loading

github-actions bot left a comment •

edited

Loading