Skip to content

pkg/contexts: expand CRE.Normalized #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmank88 merged 1 commit into from
Dec 31, 2025
Merged

pkg/contexts: expand CRE.Normalized #1746

jmank88 merged 1 commit into from
Dec 31, 2025
+13 −5

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Dec 30, 2025

@jmank88 jmank88 requested a review from bolekk December 30, 2025 20:11
jmank88
jmank88 commented Dec 30, 2025
View reviewed changes
pkg/contexts/contexts.go
Copy link
Contributor Author

@jmank88 jmank88 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bolekk Do you have any concerns with making the others lower-case as well?

Copy link
Contributor

@bolekk bolekk Dec 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns but are you sure this is the best way to handle it? What if somebody misspells "owner_"? It will be silently ignored again. I thought that it might be better to enforce one single format in CLD (and optionally here too).

Copy link
Contributor Author

@jmank88 jmank88 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to being stricter on the settings side, but I would worry about having to update this code in the future if it were too strict. Is there a chance that formats could change? Or is that not something to worry about?

Copy link
Contributor Author

@jmank88 jmank88 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and we don't have an existing error here, so it would be messy to reject things

Copy link
Contributor

@bolekk bolekk Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so let's be more permissive here but also add validations in CLD.

@github-actions
Copy link

github-actions bot commented Dec 30, 2025 •
edited
Loading

✅ API Diff Results - No breaking changes

📄 View full apidiff report

@jmank88 jmank88 force-pushed the CRE-1612-cre-settings-key-prefix branch from 29a8f35 to 00dd979 Compare December 30, 2025 20:17
@jmank88 jmank88 marked this pull request as ready for review December 31, 2025 13:51
@jmank88 jmank88 requested a review from a team as a code owner December 31, 2025 13:51
@jmank88 jmank88 requested a review from pavel-raykov December 31, 2025 13:52
@jmank88 jmank88 added this pull request to the merge queue Dec 31, 2025
Merged via the queue into main with commit 3fbd98c Dec 31, 2025
36 checks passed
@jmank88 jmank88 deleted the CRE-1612-cre-settings-key-prefix branch December 31, 2025 14:03
@jmank88 jmank88 mentioned this pull request Dec 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bolekk bolekk bolekk approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmank88 @bolekk @pavel-raykov