CRE-1601: Ring OCR plugin for shard orchestration #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchain0
had a problem deploying
to
integration
GitHub Actions
Failure
✅ API Diff Results - No breaking changes |
mchain0
had a problem deploying
to
integration
GitHub Actions
Failure
mchain0
had a problem deploying
to
integration
GitHub Actions
Failure
mchain0
had a problem deploying
to
integration
GitHub Actions
Failure
product-security-plaid-production
bot
requested review from
DylanTinianov and
george-dorin
bolekk
requested changes
Dec 23, 2025
…tions in the consensus
bolekk
reviewed
Dec 31, 2025
…vations validation; ring performance improvements
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…rent data from the arbiter
bolekk
reviewed
Dec 31, 2025
bolekk
approved these changes
Jan 2, 2026
chudilka1
reviewed
Jan 2, 2026
Comment on lines
+17
to
+35
| t.Run("with_nil_config", func(t *testing.T) { | ||
| f, err := NewFactory(store, arbiter, lggr, nil) | ||
| require.NoError(t, err) | ||
| require.NotNil(t, f) | ||
| }) | ||
|
|
||
| t.Run("with_custom_config", func(t *testing.T) { | ||
| cfg := &ConsensusConfig{BatchSize: 50} | ||
| f, err := NewFactory(store, arbiter, lggr, cfg) | ||
| require.NoError(t, err) | ||
| require.NotNil(t, f) | ||
| }) | ||
|
|
||
| t.Run("nil_arbiter_returns_error", func(t *testing.T) { | ||
| _, err := NewFactory(store, nil, lggr, nil) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "arbiterScaler is required") | ||
| }) | ||
| } |
Contributor
There was a problem hiding this comment.
Minor - these tests may be moved to a table tests to avoid repeated logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRE-1601